StagefrighRecorder:check mWriter before using fd

ftruncate(fd) would be useless if mWriter was NULL already.
Hence moved mWriter nullptr check before ftruncate(fd).

Bug: 128366317

Test: atest CtsMediaTestCases:android.media.cts.MediaRecorderTest

Change-Id: I46b8c4718bc8a90712b7ec0b54d8239106106018
gugelfrei
Gopalakrishnan Nallasamy 5 years ago
parent baf2d2c69a
commit 14c10ebbf4

@ -400,12 +400,14 @@ status_t StagefrightRecorder::setNextOutputFile(int fd) {
return -EBADF;
}
// start with a clean, empty file
ftruncate(fd, 0);
if (mWriter == NULL) {
if (mWriter == nullptr) {
ALOGE("setNextOutputFile failed. Writer has been freed");
return INVALID_OPERATION;
}
// start with a clean, empty file
ftruncate(fd, 0);
return mWriter->setNextFd(fd);
}

Loading…
Cancel
Save