Merge "MPEG4Writer:Fix MetaData use-after-free issue" am: e6b6db59fc

Change-Id: I9485f77b567543c5b3cec241ad8c7cccdaff1842
4 years ago · 2308ec5ee0
parent 956e2618bd e6b6db59fc
commit 2308ec5ee0
1 changed files with 2 additions and 1 deletions
--- a/media/libstagefright/MPEG4Writer.cpp
+++ b/media/libstagefright/MPEG4Writer.cpp
@ -614,7 +614,8 @@ status_t MPEG4Writer::addSource(const sp<MediaSource> &source) {
    CHECK(source.get() != NULL);

    const char *mime;
-    source->getFormat()->findCString(kKeyMIMEType, &mime);
+    sp<MetaData> meta = source->getFormat();
+    meta->findCString(kKeyMIMEType, &mime);

    if (Track::getFourCCForMime(mime) == NULL) {
        ALOGE("Unsupported mime '%s'", mime);