Merge "camera2 vndk: Initialize uninitialized members of OutputConfiguration in wrapper constructor."

gugelfrei
Jayant Chowdhary 5 years ago committed by Android (Google) Code Review
commit 3689dfb9e5

@ -300,7 +300,6 @@ camera_status_t CameraDevice::updateOutputConfigurationLocked(ACaptureSessionOut
OutputConfigurationWrapper outConfigW;
OutputConfiguration &outConfig = outConfigW.mOutputConfiguration;
outConfig.rotation = utils::convertToHidl(output->mRotation);
outConfig.windowGroupId = -1; // ndk doesn't support inter OutputConfiguration buffer sharing.
outConfig.windowHandles.resize(output->mSharedWindows.size() + 1);
outConfig.windowHandles[0] = output->mWindow;
outConfig.physicalCameraId = output->mPhysicalCameraId;

@ -99,7 +99,15 @@ struct OutputConfigurationWrapper {
return mOutputConfiguration;
}
OutputConfigurationWrapper() = default;
OutputConfigurationWrapper() {
mOutputConfiguration.rotation = OutputConfiguration::Rotation::R0;
// The ndk currently doesn't support deferred surfaces
mOutputConfiguration.isDeferred = false;
mOutputConfiguration.width = 0;
mOutputConfiguration.height = 0;
// ndk doesn't support inter OutputConfiguration buffer sharing.
mOutputConfiguration.windowGroupId = -1;
};
OutputConfigurationWrapper(OutputConfiguration &outputConfiguration)
: mOutputConfiguration((outputConfiguration)) { }

Loading…
Cancel
Save