diff --git a/camera/ndk/impl/ACameraDevice.cpp b/camera/ndk/impl/ACameraDevice.cpp index 793bbc4761..ffabf7b27c 100644 --- a/camera/ndk/impl/ACameraDevice.cpp +++ b/camera/ndk/impl/ACameraDevice.cpp @@ -633,7 +633,7 @@ CameraDevice::configureStreamsLocked(const ACaptureSessionOutputContainer* outpu } std::set> outputSet; - for (auto outConfig : outputs->mOutputs) { + for (const auto& outConfig : outputs->mOutputs) { ANativeWindow* anw = outConfig.mWindow; sp iGBP(nullptr); ret = getIGBPfromAnw(anw, iGBP); @@ -706,7 +706,7 @@ CameraDevice::configureStreamsLocked(const ACaptureSessionOutputContainer* outpu } // add new streams - for (auto outputPair : addSet) { + for (const auto& outputPair : addSet) { int streamId; remoteRet = mRemote->createStream(outputPair.second, &streamId); if (!remoteRet.isOk()) { @@ -839,7 +839,7 @@ CameraDevice::onCaptureErrorLocked( const auto& gbps = outputPairIt->second.second.getGraphicBufferProducers(); for (const auto& outGbp : gbps) { - for (auto surface : request->mSurfaceList) { + for (const auto& surface : request->mSurfaceList) { if (surface->getIGraphicBufferProducer() == outGbp) { ANativeWindow* anw = static_cast(surface.get()); ALOGV("Camera %s Lost output buffer for ANW %p frame %" PRId64, diff --git a/media/libeffects/config/src/EffectsConfig.cpp b/media/libeffects/config/src/EffectsConfig.cpp index 351b1ee8c8..76b4adc201 100644 --- a/media/libeffects/config/src/EffectsConfig.cpp +++ b/media/libeffects/config/src/EffectsConfig.cpp @@ -305,7 +305,7 @@ ParsingResult parse(const char* path) { return parseWithPath(path); } - for (std::string location : DEFAULT_LOCATIONS) { + for (const std::string& location : DEFAULT_LOCATIONS) { std::string defaultPath = location + '/' + DEFAULT_NAME; if (access(defaultPath.c_str(), R_OK) != 0) { continue; diff --git a/services/camera/libcameraservice/api2/CameraDeviceClient.cpp b/services/camera/libcameraservice/api2/CameraDeviceClient.cpp index 84428c2460..567b15f67e 100644 --- a/services/camera/libcameraservice/api2/CameraDeviceClient.cpp +++ b/services/camera/libcameraservice/api2/CameraDeviceClient.cpp @@ -252,7 +252,7 @@ binder::Status CameraDeviceClient::submitRequestList( Vector outputStreamIds; std::vector requestedPhysicalIds; if (request.mSurfaceList.size() > 0) { - for (sp surface : request.mSurfaceList) { + for (const sp& surface : request.mSurfaceList) { if (surface == 0) continue; int32_t streamId; diff --git a/services/camera/libcameraservice/device3/Camera3Device.cpp b/services/camera/libcameraservice/device3/Camera3Device.cpp index c85d00fd5c..a041ef5c8d 100644 --- a/services/camera/libcameraservice/device3/Camera3Device.cpp +++ b/services/camera/libcameraservice/device3/Camera3Device.cpp @@ -175,7 +175,7 @@ status_t Camera3Device::initialize(sp manager, const Stri session->interfaceChain([]( ::android::hardware::hidl_vec<::android::hardware::hidl_string> interfaceChain) { ALOGV("Session interface chain:"); - for (auto iface : interfaceChain) { + for (const auto& iface : interfaceChain) { ALOGV(" %s", iface.c_str()); } }); diff --git a/services/oboeservice/AAudioEndpointManager.cpp b/services/oboeservice/AAudioEndpointManager.cpp index 04fee13258..e0db261656 100644 --- a/services/oboeservice/AAudioEndpointManager.cpp +++ b/services/oboeservice/AAudioEndpointManager.cpp @@ -108,7 +108,7 @@ sp AAudioEndpointManager::findExclusiveEndpoint_l( const AAudioStreamConfiguration &configuration) { sp endpoint; mExclusiveSearchCount++; - for (const auto ep : mExclusiveStreams) { + for (const auto& ep : mExclusiveStreams) { if (ep->matches(configuration)) { mExclusiveFoundCount++; endpoint = ep; @@ -126,7 +126,7 @@ sp AAudioEndpointManager::findSharedEndpoint_l( const AAudioStreamConfiguration &configuration) { sp endpoint; mSharedSearchCount++; - for (const auto ep : mSharedStreams) { + for (const auto& ep : mSharedStreams) { if (ep->matches(configuration)) { mSharedFoundCount++; endpoint = ep; diff --git a/services/oboeservice/AAudioServiceEndpoint.cpp b/services/oboeservice/AAudioServiceEndpoint.cpp index 03490344a9..69068f547c 100644 --- a/services/oboeservice/AAudioServiceEndpoint.cpp +++ b/services/oboeservice/AAudioServiceEndpoint.cpp @@ -68,7 +68,7 @@ std::string AAudioServiceEndpoint::dump() const { result << " Connected: " << mConnected.load() << "\n"; result << " Registered Streams:" << "\n"; result << AAudioServiceStreamShared::dumpHeader() << "\n"; - for (const auto stream : mRegisteredStreams) { + for (const auto& stream : mRegisteredStreams) { result << stream->dump() << "\n"; } @@ -81,7 +81,7 @@ std::string AAudioServiceEndpoint::dump() const { // @return true if stream found bool AAudioServiceEndpoint::isStreamRegistered(audio_port_handle_t portHandle) { std::lock_guard lock(mLockStreams); - for (const auto stream : mRegisteredStreams) { + for (const auto& stream : mRegisteredStreams) { if (stream->getPortHandle() == portHandle) { return true; } @@ -92,7 +92,7 @@ bool AAudioServiceEndpoint::isStreamRegistered(audio_port_handle_t portHandle) { void AAudioServiceEndpoint::disconnectRegisteredStreams() { std::lock_guard lock(mLockStreams); mConnected.store(false); - for (const auto stream : mRegisteredStreams) { + for (const auto& stream : mRegisteredStreams) { ALOGD("disconnectRegisteredStreams() stop and disconnect %p", stream.get()); stream->stop(); stream->disconnect(); diff --git a/services/oboeservice/AAudioServiceEndpointCapture.cpp b/services/oboeservice/AAudioServiceEndpointCapture.cpp index efac7888ad..cc942f44ac 100644 --- a/services/oboeservice/AAudioServiceEndpointCapture.cpp +++ b/services/oboeservice/AAudioServiceEndpointCapture.cpp @@ -81,7 +81,7 @@ void *AAudioServiceEndpointCapture::callbackLoop() { { // brackets are for lock_guard std::lock_guard lock(mLockStreams); - for (const auto clientStream : mRegisteredStreams) { + for (const auto& clientStream : mRegisteredStreams) { if (clientStream->isRunning()) { int64_t clientFramesWritten = 0; sp streamShared = diff --git a/services/oboeservice/AAudioServiceEndpointMMAP.cpp b/services/oboeservice/AAudioServiceEndpointMMAP.cpp index f30f9bbb8a..5a429c9dbd 100644 --- a/services/oboeservice/AAudioServiceEndpointMMAP.cpp +++ b/services/oboeservice/AAudioServiceEndpointMMAP.cpp @@ -373,7 +373,7 @@ void AAudioServiceEndpointMMAP::onVolumeChanged(audio_channel_mask_t channels, float volume = values[0]; ALOGD("%s(%p) volume[0] = %f", __func__, this, volume); std::lock_guard lock(mLockStreams); - for(const auto stream : mRegisteredStreams) { + for(const auto& stream : mRegisteredStreams) { stream->onVolumeChanged(volume); } }; diff --git a/services/oboeservice/AAudioServiceEndpointPlay.cpp b/services/oboeservice/AAudioServiceEndpointPlay.cpp index a274466c3e..ebba32dff0 100644 --- a/services/oboeservice/AAudioServiceEndpointPlay.cpp +++ b/services/oboeservice/AAudioServiceEndpointPlay.cpp @@ -84,7 +84,7 @@ void *AAudioServiceEndpointPlay::callbackLoop() { int64_t mmapFramesWritten = getStreamInternal()->getFramesWritten(); std::lock_guard lock(mLockStreams); - for (const auto clientStream : mRegisteredStreams) { + for (const auto& clientStream : mRegisteredStreams) { int64_t clientFramesRead = 0; bool allowUnderflow = true;