Revert "media: remove IGraphicBufferSource.aidl"

This reverts commit 2f6a4b8345.

Reason for revert: broken build b/143248118

Change-Id: I1d81103a6992f98264d9afeaa055cab500f0c0b3
gugelfrei
Winson Chiu 5 years ago
parent 2f6a4b8345
commit 47eaa19471

@ -9,6 +9,7 @@ cc_library_shared {
"CCodecConfig.cpp",
"Codec2Buffer.cpp",
"Codec2InfoBuilder.cpp",
"Omx2IGraphicBufferSource.cpp",
"PipelineWatcher.cpp",
"ReflectedParamUpdater.cpp",
"SkipCutBuffer.cpp",

@ -26,6 +26,7 @@
#include <C2ParamInternal.h>
#include <C2PlatformSupport.h>
#include <android/IGraphicBufferSource.h>
#include <android/IOMXBufferSource.h>
#include <android/hardware/media/omx/1.0/IGraphicBufferSource.h>
#include <android/hardware/media/omx/1.0/IOmx.h>
@ -34,11 +35,8 @@
#include <gui/IGraphicBufferProducer.h>
#include <gui/Surface.h>
#include <gui/bufferqueue/1.0/H2BGraphicBufferProducer.h>
#include <media/omx/1.0/WOmxNode.h>
#include <media/openmax/OMX_Core.h>
#include <media/omx/1.0/WGraphicBufferSource.h>
#include <media/openmax/OMX_IndexExt.h>
#include <media/stagefright/omx/1.0/WGraphicBufferSource.h>
#include <media/stagefright/omx/OmxGraphicBufferSource.h>
#include <media/stagefright/BufferProducerWrapper.h>
#include <media/stagefright/MediaCodecConstants.h>
#include <media/stagefright/PersistentSurface.h>
@ -47,6 +45,7 @@
#include "CCodec.h"
#include "CCodecBufferChannel.h"
#include "InputSurfaceWrapper.h"
#include "Omx2IGraphicBufferSource.h"
extern "C" android::PersistentSurface *CreateInputSurface();
@ -55,10 +54,9 @@ namespace android {
using namespace std::chrono_literals;
using ::android::hardware::graphics::bufferqueue::V1_0::utils::H2BGraphicBufferProducer;
using android::base::StringPrintf;
using BGraphicBufferSource = ::android::IGraphicBufferSource;
using ::android::hardware::media::c2::V1_0::IInputSurface;
typedef hardware::media::omx::V1_0::IGraphicBufferSource HGraphicBufferSource;
namespace {
class CCodecWatchdog : public AHandler {
@ -182,10 +180,9 @@ private:
class GraphicBufferSourceWrapper : public InputSurfaceWrapper {
public:
typedef hardware::media::omx::V1_0::Status OmxStatus;
// explicit GraphicBufferSourceWrapper(const sp<BGraphicBufferSource> &source) : mSource(source) {}
GraphicBufferSourceWrapper(
const sp<HGraphicBufferSource> &source,
const sp<BGraphicBufferSource> &source,
uint32_t width,
uint32_t height,
uint64_t usage)
@ -197,7 +194,6 @@ public:
status_t connect(const std::shared_ptr<Codec2Client::Component> &comp) override {
mNode = new C2OMXNode(comp);
mOmxNode = new hardware::media::omx::V1_0::utils::TWOmxNode(mNode);
mNode->setFrameSize(mWidth, mHeight);
// Usage is queried during configure(), so setting it beforehand.
@ -208,8 +204,7 @@ public:
// NOTE: we do not use/pass through color aspects from GraphicBufferSource as we
// communicate that directly to the component.
mSource->configure(
mOmxNode, static_cast<hardware::graphics::common::V1_0::Dataspace>(mDataSpace));
mSource->configure(mNode, mDataSpace);
return OK;
}
@ -225,16 +220,21 @@ public:
source->onOmxIdle();
source->onOmxLoaded();
mNode.clear();
mOmxNode.clear();
}
status_t GetStatus(hardware::Return<OmxStatus> &&status) {
if (status.isOk()) {
return static_cast<status_t>(status.withDefault(OmxStatus::UNKNOWN_ERROR));
} else if (status.isDeadObject()) {
return DEAD_OBJECT;
status_t GetStatus(const binder::Status &status) {
status_t err = OK;
if (!status.isOk()) {
err = status.serviceSpecificErrorCode();
if (err == OK) {
err = status.transactionError();
if (err == OK) {
// binder status failed, but there is no servie or transaction error
err = UNKNOWN_ERROR;
}
}
}
return UNKNOWN_ERROR;
return err;
}
status_t start() override {
@ -359,15 +359,7 @@ public:
err = res;
} else {
status << " delayUs";
hardware::Return<void> trans = mSource->getStopTimeOffsetUs(
[&res, &delayUs = config.mInputDelayUs](
auto status, auto stopTimeOffsetUs) {
res = static_cast<status_t>(status);
delayUs = stopTimeOffsetUs;
});
if (!trans.isOk()) {
res = trans.isDeadObject() ? DEAD_OBJECT : UNKNOWN_ERROR;
}
res = GetStatus(mSource->getStopTimeOffsetUs(&config.mInputDelayUs));
if (res != OK) {
status << " (=> " << asString(res) << ")";
} else {
@ -396,9 +388,8 @@ public:
}
private:
sp<HGraphicBufferSource> mSource;
sp<BGraphicBufferSource> mSource;
sp<C2OMXNode> mNode;
sp<hardware::media::omx::V1_0::IOmxNode> mOmxNode;
uint32_t mWidth;
uint32_t mHeight;
Config mConfig;
@ -1101,7 +1092,9 @@ sp<PersistentSurface> CCodec::CreateOmxInputSurface() {
gbs = source;
});
if (transStatus.isOk() && s == OmxStatus::OK) {
return new PersistentSurface(new H2BGraphicBufferProducer(gbp), gbs);
return new PersistentSurface(
new H2BGraphicBufferProducer(gbp),
sp<::android::IGraphicBufferSource>(new LWGraphicBufferSource(gbs)));
}
return nullptr;
@ -1132,28 +1125,28 @@ void CCodec::createInputSurface() {
}
sp<PersistentSurface> persistentSurface = CreateCompatibleInputSurface();
sp<hidl::base::V1_0::IBase> hidlTarget = persistentSurface->getHidlTarget();
sp<IInputSurface> hidlInputSurface = IInputSurface::castFrom(hidlTarget);
sp<HGraphicBufferSource> gbs = HGraphicBufferSource::castFrom(hidlTarget);
if (hidlInputSurface) {
if (persistentSurface->getHidlTarget()) {
sp<IInputSurface> hidlInputSurface = IInputSurface::castFrom(
persistentSurface->getHidlTarget());
if (!hidlInputSurface) {
ALOGE("Corrupted input surface");
mCallback->onInputSurfaceCreationFailed(UNKNOWN_ERROR);
return;
}
std::shared_ptr<Codec2Client::InputSurface> inputSurface =
std::make_shared<Codec2Client::InputSurface>(hidlInputSurface);
err = setupInputSurface(std::make_shared<C2InputSurfaceWrapper>(
inputSurface));
bufferProducer = inputSurface->getGraphicBufferProducer();
} else if (gbs) {
} else {
int32_t width = 0;
(void)outputFormat->findInt32("width", &width);
int32_t height = 0;
(void)outputFormat->findInt32("height", &height);
err = setupInputSurface(std::make_shared<GraphicBufferSourceWrapper>(
gbs, width, height, usage));
persistentSurface->getBufferSource(), width, height, usage));
bufferProducer = persistentSurface->getBufferProducer();
} else {
ALOGE("Corrupted input surface");
mCallback->onInputSurfaceCreationFailed(UNKNOWN_ERROR);
return;
}
if (err != OK) {
@ -1219,10 +1212,15 @@ void CCodec::setInputSurface(const sp<PersistentSurface> &surface) {
outputFormat = config->mOutputFormat;
usage = config->mISConfig ? config->mISConfig->mUsage : 0;
}
sp<hidl::base::V1_0::IBase> hidlTarget = surface->getHidlTarget();
sp<IInputSurface> inputSurface = IInputSurface::castFrom(hidlTarget);
sp<HGraphicBufferSource> gbs = HGraphicBufferSource::castFrom(hidlTarget);
if (inputSurface) {
auto hidlTarget = surface->getHidlTarget();
if (hidlTarget) {
sp<IInputSurface> inputSurface =
IInputSurface::castFrom(hidlTarget);
if (!inputSurface) {
ALOGE("Failed to set input surface: Corrupted surface.");
mCallback->onInputSurfaceDeclined(UNKNOWN_ERROR);
return;
}
status_t err = setupInputSurface(std::make_shared<C2InputSurfaceWrapper>(
std::make_shared<Codec2Client::InputSurface>(inputSurface)));
if (err != OK) {
@ -1230,22 +1228,18 @@ void CCodec::setInputSurface(const sp<PersistentSurface> &surface) {
mCallback->onInputSurfaceDeclined(err);
return;
}
} else if (gbs) {
} else {
int32_t width = 0;
(void)outputFormat->findInt32("width", &width);
int32_t height = 0;
(void)outputFormat->findInt32("height", &height);
status_t err = setupInputSurface(std::make_shared<GraphicBufferSourceWrapper>(
gbs, width, height, usage));
surface->getBufferSource(), width, height, usage));
if (err != OK) {
ALOGE("Failed to set up input surface: %d", err);
mCallback->onInputSurfaceDeclined(err);
return;
}
} else {
ALOGE("Failed to set input surface: Corrupted surface.");
mCallback->onInputSurfaceDeclined(UNKNOWN_ERROR);
return;
}
mCallback->onInputSurfaceAccepted(inputFormat, outputFormat);
}
@ -1873,7 +1867,6 @@ extern "C" android::CodecBase *CreateCodec() {
// Create Codec 2.0 input surface
extern "C" android::PersistentSurface *CreateInputSurface() {
using namespace android;
using ::android::hardware::media::omx::V1_0::implementation::TWGraphicBufferSource;
// Attempt to create a Codec2's input surface.
std::shared_ptr<Codec2Client::InputSurface> inputSurface =
Codec2Client::CreateInputSurface();
@ -1887,7 +1880,9 @@ extern "C" android::PersistentSurface *CreateInputSurface() {
return nullptr;
}
return new PersistentSurface(
gbs->getIGraphicBufferProducer(), new TWGraphicBufferSource(gbs));
gbs->getIGraphicBufferProducer(),
sp<IGraphicBufferSource>(
new Omx2IGraphicBufferSource(gbs)));
} else {
return nullptr;
}

@ -0,0 +1,185 @@
/*
* Copyright 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifdef __LP64__
#define OMX_ANDROID_COMPILE_AS_32BIT_ON_64BIT_PLATFORMS
#endif
//#define LOG_NDEBUG 0
#define LOG_TAG "Omx2IGraphicBufferSource"
#include <android-base/logging.h>
#include "Omx2IGraphicBufferSource.h"
#include <android/BnOMXBufferSource.h>
#include <media/OMXBuffer.h>
#include <media/stagefright/omx/OMXUtils.h>
#include <OMX_Component.h>
#include <OMX_Index.h>
#include <OMX_IndexExt.h>
namespace android {
namespace /* unnamed */ {
// OmxGraphicBufferSource -> IOMXBufferSource
struct OmxGbs2IOmxBs : public BnOMXBufferSource {
sp<OmxGraphicBufferSource> mBase;
OmxGbs2IOmxBs(sp<OmxGraphicBufferSource> const& base) : mBase{base} {}
BnStatus onOmxExecuting() override {
return mBase->onOmxExecuting();
}
BnStatus onOmxIdle() override {
return mBase->onOmxIdle();
}
BnStatus onOmxLoaded() override {
return mBase->onOmxLoaded();
}
BnStatus onInputBufferAdded(int32_t bufferId) override {
return mBase->onInputBufferAdded(bufferId);
}
BnStatus onInputBufferEmptied(
int32_t bufferId,
OMXFenceParcelable const& fenceParcel) override {
return mBase->onInputBufferEmptied(bufferId, fenceParcel.get());
}
};
struct OmxNodeWrapper : public IOmxNodeWrapper {
sp<IOMXNode> mBase;
OmxNodeWrapper(sp<IOMXNode> const& base) : mBase{base} {}
status_t emptyBuffer(
int32_t bufferId, uint32_t flags,
const sp<GraphicBuffer> &buffer,
int64_t timestamp, int fenceFd) override {
return mBase->emptyBuffer(bufferId, buffer, flags, timestamp, fenceFd);
}
void dispatchDataSpaceChanged(
int32_t dataSpace, int32_t aspects, int32_t pixelFormat) override {
omx_message msg{};
msg.type = omx_message::EVENT;
msg.fenceFd = -1;
msg.u.event_data.event = OMX_EventDataSpaceChanged;
msg.u.event_data.data1 = dataSpace;
msg.u.event_data.data2 = aspects;
msg.u.event_data.data3 = pixelFormat;
mBase->dispatchMessage(msg);
}
};
} // unnamed namespace
// Omx2IGraphicBufferSource
Omx2IGraphicBufferSource::Omx2IGraphicBufferSource(
sp<OmxGraphicBufferSource> const& base)
: mBase{base},
mOMXBufferSource{new OmxGbs2IOmxBs(base)} {
}
BnStatus Omx2IGraphicBufferSource::setSuspend(
bool suspend, int64_t timeUs) {
return BnStatus::fromStatusT(mBase->setSuspend(suspend, timeUs));
}
BnStatus Omx2IGraphicBufferSource::setRepeatPreviousFrameDelayUs(
int64_t repeatAfterUs) {
return BnStatus::fromStatusT(mBase->setRepeatPreviousFrameDelayUs(repeatAfterUs));
}
BnStatus Omx2IGraphicBufferSource::setMaxFps(float maxFps) {
return BnStatus::fromStatusT(mBase->setMaxFps(maxFps));
}
BnStatus Omx2IGraphicBufferSource::setTimeLapseConfig(
double fps, double captureFps) {
return BnStatus::fromStatusT(mBase->setTimeLapseConfig(fps, captureFps));
}
BnStatus Omx2IGraphicBufferSource::setStartTimeUs(
int64_t startTimeUs) {
return BnStatus::fromStatusT(mBase->setStartTimeUs(startTimeUs));
}
BnStatus Omx2IGraphicBufferSource::setStopTimeUs(
int64_t stopTimeUs) {
return BnStatus::fromStatusT(mBase->setStopTimeUs(stopTimeUs));
}
BnStatus Omx2IGraphicBufferSource::getStopTimeOffsetUs(
int64_t *stopTimeOffsetUs) {
return BnStatus::fromStatusT(mBase->getStopTimeOffsetUs(stopTimeOffsetUs));
}
BnStatus Omx2IGraphicBufferSource::setColorAspects(
int32_t aspects) {
return BnStatus::fromStatusT(mBase->setColorAspects(aspects));
}
BnStatus Omx2IGraphicBufferSource::setTimeOffsetUs(
int64_t timeOffsetsUs) {
return BnStatus::fromStatusT(mBase->setTimeOffsetUs(timeOffsetsUs));
}
BnStatus Omx2IGraphicBufferSource::signalEndOfInputStream() {
return BnStatus::fromStatusT(mBase->signalEndOfInputStream());
}
BnStatus Omx2IGraphicBufferSource::configure(
const sp<IOMXNode>& omxNode, int32_t dataSpace) {
if (omxNode == NULL) {
return BnStatus::fromServiceSpecificError(BAD_VALUE);
}
// Do setInputSurface() first, the node will try to enable metadata
// mode on input, and does necessary error checking. If this fails,
// we can't use this input surface on the node.
status_t err = omxNode->setInputSurface(mOMXBufferSource);
if (err != NO_ERROR) {
ALOGE("Unable to set input surface: %d", err);
return BnStatus::fromServiceSpecificError(err);
}
uint32_t consumerUsage;
if (omxNode->getParameter(
(OMX_INDEXTYPE)OMX_IndexParamConsumerUsageBits,
&consumerUsage, sizeof(consumerUsage)) != OK) {
consumerUsage = 0;
}
OMX_PARAM_PORTDEFINITIONTYPE def;
InitOMXParams(&def);
def.nPortIndex = 0; // kPortIndexInput
err = omxNode->getParameter(
OMX_IndexParamPortDefinition, &def, sizeof(def));
if (err != NO_ERROR) {
ALOGE("Failed to get port definition: %d", err);
return BnStatus::fromServiceSpecificError(UNKNOWN_ERROR);
}
return BnStatus::fromStatusT(mBase->configure(
new OmxNodeWrapper(omxNode),
dataSpace,
def.nBufferCountActual,
def.format.video.nFrameWidth,
def.format.video.nFrameHeight,
consumerUsage));
}
} // namespace android

@ -0,0 +1,47 @@
/*
* Copyright 2019 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef OMX_2_IGRAPHICBUFFERSOURCE_H_
#define OMX_2_IGRAPHICBUFFERSOURCE_H_
#include <android/BnGraphicBufferSource.h>
#include <media/stagefright/omx/OmxGraphicBufferSource.h>
namespace android {
using BnStatus = ::android::binder::Status;
struct Omx2IGraphicBufferSource : public BnGraphicBufferSource {
sp<OmxGraphicBufferSource> mBase;
sp<IOMXBufferSource> mOMXBufferSource;
Omx2IGraphicBufferSource(sp<OmxGraphicBufferSource> const& base);
BnStatus configure(const sp<IOMXNode>& omxNode, int32_t dataSpace) override;
BnStatus setSuspend(bool suspend, int64_t timeUs) override;
BnStatus setRepeatPreviousFrameDelayUs(int64_t repeatAfterUs) override;
BnStatus setMaxFps(float maxFps) override;
BnStatus setTimeLapseConfig(double fps, double captureFps) override;
BnStatus setStartTimeUs(int64_t startTimeUs) override;
BnStatus setStopTimeUs(int64_t stopTimeUs) override;
BnStatus getStopTimeOffsetUs(int64_t *stopTimeOffsetUs) override;
BnStatus setColorAspects(int32_t aspects) override;
BnStatus setTimeOffsetUs(int64_t timeOffsetsUs) override;
BnStatus signalEndOfInputStream() override;
};
} // namespace android
#endif // OMX_2_IGRAPHICBUFFERSOURCE_H_

@ -43,6 +43,7 @@ cc_library {
filegroup {
name: "libmedia_omx_aidl",
srcs: [
"aidl/android/IGraphicBufferSource.aidl",
"aidl/android/IOMXBufferSource.aidl",
],
path: "aidl",
@ -62,6 +63,7 @@ cc_library_shared {
"IOMX.cpp",
"MediaCodecBuffer.cpp",
"OMXBuffer.cpp",
"omx/1.0/WGraphicBufferSource.cpp",
"omx/1.0/WOmxBufferSource.cpp",
"omx/1.0/WOmxNode.cpp",
"omx/1.0/WOmxObserver.cpp",

@ -29,6 +29,7 @@
#include <utils/NativeHandle.h>
#include <media/omx/1.0/WOmxNode.h>
#include <android/IGraphicBufferSource.h>
#include <android/IOMXBufferSource.h>
namespace android {

@ -0,0 +1,38 @@
/*
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package android;
import android.IOMXNode;
/**
* Binder interface for controlling a graphic buffer source.
*
* @hide
*/
interface IGraphicBufferSource {
void configure(IOMXNode omxNode, int dataSpace);
void setSuspend(boolean suspend, long suspendTimeUs);
void setRepeatPreviousFrameDelayUs(long repeatAfterUs);
void setMaxFps(float maxFps);
void setTimeLapseConfig(double fps, double captureFps);
void setStartTimeUs(long startTimeUs);
void setStopTimeUs(long stopTimeUs);
long getStopTimeOffsetUs();
void setColorAspects(int aspects);
void setTimeOffsetUs(long timeOffsetsUs);
void signalEndOfInputStream();
}

@ -34,17 +34,9 @@
#include <media/openmax/OMX_VideoExt.h>
namespace android {
namespace hardware {
namespace media {
namespace omx {
namespace V1_0 {
struct IGraphicBufferSource;
} // namespace V1_0
} // namespace omx
} // namespace media
} // namespace hardware
class IGraphicBufferProducer;
class IGraphicBufferSource;
class IMemory;
class IOMXBufferSource;
class IOMXNode;
@ -90,7 +82,7 @@ public:
virtual status_t createInputSurface(
sp<IGraphicBufferProducer> *bufferProducer,
sp<hardware::media::omx::V1_0::IGraphicBufferSource> *bufferSource) = 0;
sp<IGraphicBufferSource> *bufferSource) = 0;
};
class IOMXNode : public IInterface {

@ -45,6 +45,7 @@
#include <android/hardware/media/omx/1.0/IOmxObserver.h>
#include <android/hardware/media/omx/1.0/IGraphicBufferSource.h>
#include <android/IGraphicBufferSource.h>
#include <android/IOMXBufferSource.h>
namespace android {

@ -0,0 +1,90 @@
/*
* Copyright 2016, The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef ANDROID_HARDWARE_MEDIA_OMX_V1_0_WGRAPHICBUFFERSOURCE_H
#define ANDROID_HARDWARE_MEDIA_OMX_V1_0_WGRAPHICBUFFERSOURCE_H
#include <hidl/MQDescriptor.h>
#include <hidl/Status.h>
#include <binder/Binder.h>
#include <media/IOMX.h>
#include <android/hardware/graphics/common/1.0/types.h>
#include <android/hardware/media/omx/1.0/IOmxNode.h>
#include <android/hardware/media/omx/1.0/IGraphicBufferSource.h>
#include <android/BnGraphicBufferSource.h>
namespace android {
namespace hardware {
namespace media {
namespace omx {
namespace V1_0 {
namespace utils {
using ::android::hardware::graphics::common::V1_0::Dataspace;
using ::android::hardware::media::omx::V1_0::ColorAspects;
using ::android::hardware::media::omx::V1_0::IGraphicBufferSource;
using ::android::hardware::media::omx::V1_0::IOmxNode;
using ::android::hidl::base::V1_0::IBase;
using ::android::hardware::hidl_array;
using ::android::hardware::hidl_memory;
using ::android::hardware::hidl_string;
using ::android::hardware::hidl_vec;
using ::android::hardware::Return;
using ::android::hardware::Void;
using ::android::sp;
using ::android::IOMXNode;
/**
* Wrapper classes for conversion
* ==============================
*
* Naming convention:
* - LW = Legacy Wrapper --- It wraps a Treble object inside a legacy object.
* - TW = Treble Wrapper --- It wraps a legacy object inside a Treble object.
*/
typedef ::android::binder::Status BnStatus;
typedef ::android::BnGraphicBufferSource BnGraphicBufferSource;
typedef ::android::hardware::media::omx::V1_0::IGraphicBufferSource
TGraphicBufferSource;
struct LWGraphicBufferSource : public BnGraphicBufferSource {
sp<TGraphicBufferSource> mBase;
LWGraphicBufferSource(sp<TGraphicBufferSource> const& base);
BnStatus configure(const sp<IOMXNode>& omxNode, int32_t dataSpace) override;
BnStatus setSuspend(bool suspend, int64_t timeUs) override;
BnStatus setRepeatPreviousFrameDelayUs(int64_t repeatAfterUs) override;
BnStatus setMaxFps(float maxFps) override;
BnStatus setTimeLapseConfig(double fps, double captureFps) override;
BnStatus setStartTimeUs(int64_t startTimeUs) override;
BnStatus setStopTimeUs(int64_t stopTimeUs) override;
BnStatus getStopTimeOffsetUs(int64_t *stopTimeOffsetUs) override;
BnStatus setColorAspects(int32_t aspects) override;
BnStatus setTimeOffsetUs(int64_t timeOffsetsUs) override;
BnStatus signalEndOfInputStream() override;
};
} // namespace utils
} // namespace V1_0
} // namespace omx
} // namespace media
} // namespace hardware
} // namespace android
#endif // ANDROID_HARDWARE_MEDIA_OMX_V1_0_WGRAPHICBUFFERSOURCE_H

@ -67,7 +67,7 @@ struct LWOmx : public IOMX {
sp<IOMXNode>* omxNode) override;
status_t createInputSurface(
sp<::android::IGraphicBufferProducer>* bufferProducer,
sp<::android::hardware::media::omx::V1_0::IGraphicBufferSource>* bufferSource) override;
sp<::android::IGraphicBufferSource>* bufferSource) override;
};
} // namespace utils

@ -0,0 +1,98 @@
/*
* Copyright 2016, The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <media/omx/1.0/WGraphicBufferSource.h>
#include <media/omx/1.0/WOmxNode.h>
#include <media/omx/1.0/Conversion.h>
namespace android {
namespace hardware {
namespace media {
namespace omx {
namespace V1_0 {
namespace utils {
// LWGraphicBufferSource
LWGraphicBufferSource::LWGraphicBufferSource(
sp<TGraphicBufferSource> const& base) : mBase(base) {
}
BnStatus LWGraphicBufferSource::configure(
const sp<IOMXNode>& omxNode, int32_t dataSpace) {
sp<IOmxNode> hOmxNode = omxNode->getHalInterface<IOmxNode>();
return toBinderStatus(mBase->configure(
hOmxNode == nullptr ? new TWOmxNode(omxNode) : hOmxNode,
toHardwareDataspace(dataSpace)));
}
BnStatus LWGraphicBufferSource::setSuspend(
bool suspend, int64_t timeUs) {
return toBinderStatus(mBase->setSuspend(suspend, timeUs));
}
BnStatus LWGraphicBufferSource::setRepeatPreviousFrameDelayUs(
int64_t repeatAfterUs) {
return toBinderStatus(mBase->setRepeatPreviousFrameDelayUs(repeatAfterUs));
}
BnStatus LWGraphicBufferSource::setMaxFps(float maxFps) {
return toBinderStatus(mBase->setMaxFps(maxFps));
}
BnStatus LWGraphicBufferSource::setTimeLapseConfig(
double fps, double captureFps) {
return toBinderStatus(mBase->setTimeLapseConfig(fps, captureFps));
}
BnStatus LWGraphicBufferSource::setStartTimeUs(
int64_t startTimeUs) {
return toBinderStatus(mBase->setStartTimeUs(startTimeUs));
}
BnStatus LWGraphicBufferSource::setStopTimeUs(
int64_t stopTimeUs) {
return toBinderStatus(mBase->setStopTimeUs(stopTimeUs));
}
BnStatus LWGraphicBufferSource::getStopTimeOffsetUs(
int64_t *stopTimeOffsetUs) {
return toBinderStatus(mBase->getStopTimeOffsetUs(
[stopTimeOffsetUs](auto, auto offsetUs) {
*stopTimeOffsetUs = offsetUs;
}));
}
BnStatus LWGraphicBufferSource::setColorAspects(
int32_t aspects) {
return toBinderStatus(mBase->setColorAspects(
toHardwareColorAspects(aspects)));
}
BnStatus LWGraphicBufferSource::setTimeOffsetUs(
int64_t timeOffsetsUs) {
return toBinderStatus(mBase->setTimeOffsetUs(timeOffsetsUs));
}
BnStatus LWGraphicBufferSource::signalEndOfInputStream() {
return toBinderStatus(mBase->signalEndOfInputStream());
}
} // namespace utils
} // namespace V1_0
} // namespace omx
} // namespace media
} // namespace hardware
} // namespace android

@ -18,6 +18,7 @@
#include <media/omx/1.0/WOmx.h>
#include <media/omx/1.0/WOmxNode.h>
#include <media/omx/1.0/WOmxObserver.h>
#include <media/omx/1.0/WGraphicBufferSource.h>
#include <media/omx/1.0/Conversion.h>
namespace android {
@ -69,7 +70,7 @@ status_t LWOmx::allocateNode(
status_t LWOmx::createInputSurface(
sp<::android::IGraphicBufferProducer>* bufferProducer,
sp<::android::hardware::media::omx::V1_0::IGraphicBufferSource>* bufferSource) {
sp<::android::IGraphicBufferSource>* bufferSource) {
status_t fnStatus;
status_t transStatus = toStatusT(mBase->createInputSurface(
[&fnStatus, bufferProducer, bufferSource] (
@ -78,7 +79,7 @@ status_t LWOmx::createInputSurface(
sp<IGraphicBufferSource> const& tSource) {
fnStatus = toStatusT(status);
*bufferProducer = new H2BGraphicBufferProducer(tProducer);
*bufferSource = tSource;
*bufferSource = new LWGraphicBufferSource(tSource);
}));
return transStatus == NO_ERROR ? fnStatus : transStatus;
}

@ -24,8 +24,6 @@
#include <inttypes.h>
#include <utils/Trace.h>
#include <android/hardware/media/omx/1.0/IGraphicBufferSource.h>
#include <gui/Surface.h>
#include <media/stagefright/ACodec.h>
@ -47,7 +45,6 @@
#include <media/hardware/HardwareAPI.h>
#include <media/MediaBufferHolder.h>
#include <media/OMXBuffer.h>
#include <media/omx/1.0/Conversion.h>
#include <media/omx/1.0/WOmxNode.h>
#include <hidlmemory/mapping.h>
@ -66,9 +63,7 @@
namespace android {
typedef hardware::media::omx::V1_0::IGraphicBufferSource HGraphicBufferSource;
using hardware::media::omx::V1_0::Status;
using binder::Status;
enum {
kMaxIndicesToCheck = 32, // used when enumerating supported formats and profiles
@ -103,11 +98,16 @@ static inline status_t statusFromOMXError(int32_t omxError) {
}
}
static inline status_t statusFromBinderStatus(hardware::Return<Status> &&status) {
static inline status_t statusFromBinderStatus(const Status &status) {
if (status.isOk()) {
return static_cast<status_t>(status.withDefault(Status::UNKNOWN_ERROR));
} else if (status.isDeadObject()) {
return DEAD_OBJECT;
return OK;
}
status_t err;
if ((err = status.serviceSpecificErrorCode()) != OK) {
return err;
}
if ((err = status.transactionError()) != OK) {
return err;
}
// Other exception
return UNKNOWN_ERROR;
@ -6880,11 +6880,8 @@ status_t ACodec::LoadedState::setupInputSurface() {
return err;
}
using hardware::media::omx::V1_0::utils::TWOmxNode;
err = statusFromBinderStatus(
mCodec->mGraphicBufferSource->configure(
new TWOmxNode(mCodec->mOMXNode),
static_cast<hardware::graphics::common::V1_0::Dataspace>(dataSpace)));
mCodec->mGraphicBufferSource->configure(mCodec->mOMXNode, dataSpace));
if (err != OK) {
ALOGE("[%s] Unable to configure for node (err %d)",
mCodec->mComponentName.c_str(), err);
@ -6970,9 +6967,8 @@ status_t ACodec::LoadedState::setupInputSurface() {
}
err = statusFromBinderStatus(
mCodec->mGraphicBufferSource->setColorAspects(
hardware::media::omx::V1_0::utils::toHardwareColorAspects(
*(ColorAspects *)colorAspectsBuffer->base())));
mCodec->mGraphicBufferSource->setColorAspects(ColorUtils::packToU32(
*(ColorAspects *)colorAspectsBuffer->base())));
if (err != OK) {
ALOGE("[%s] Unable to configure color aspects (err %d)",
@ -6988,10 +6984,8 @@ void ACodec::LoadedState::onCreateInputSurface(
ALOGV("onCreateInputSurface");
sp<IGraphicBufferProducer> bufferProducer;
sp<HGraphicBufferSource> bufferSource;
status_t err = mCodec->mOMX->createInputSurface(
&bufferProducer, &bufferSource);
mCodec->mGraphicBufferSource = bufferSource;
&bufferProducer, &mCodec->mGraphicBufferSource);
if (err == OK) {
err = setupInputSurface();
@ -7024,12 +7018,8 @@ void ACodec::LoadedState::onSetInputSurface(const sp<AMessage> &msg) {
}
sp<PersistentSurface> surface = static_cast<PersistentSurface *>(obj.get());
sp<HGraphicBufferSource> hgbs = HGraphicBufferSource::castFrom(surface->getHidlTarget());
status_t err = BAD_VALUE;
if (hgbs) {
mCodec->mGraphicBufferSource = hgbs;
err = setupInputSurface();
}
mCodec->mGraphicBufferSource = surface->getBufferSource();
status_t err = setupInputSurface();
if (err == OK) {
mCodec->mCallback->onInputSurfaceAccepted(
@ -7548,14 +7538,8 @@ status_t ACodec::setParameters(const sp<AMessage> &params) {
}
int64_t stopTimeOffsetUs;
hardware::Return<void> trans = mGraphicBufferSource->getStopTimeOffsetUs(
[&err, &stopTimeOffsetUs](auto status, auto result) {
err = static_cast<status_t>(status);
stopTimeOffsetUs = result;
});
if (!trans.isOk()) {
err = trans.isDeadObject() ? DEAD_OBJECT : UNKNOWN_ERROR;
}
err = statusFromBinderStatus(
mGraphicBufferSource->getStopTimeOffsetUs(&stopTimeOffsetUs));
if (err != OK) {
ALOGE("Failed to get stop time offset (err %d)", err);

@ -21,11 +21,12 @@
#include <inttypes.h>
#include <stdlib.h>
#include "include/SecureBuffer.h"
#include "include/SharedMemoryBuffer.h"
#include "include/SoftwareRenderer.h"
#include "StagefrightPluginLoader.h"
#include <android/hardware/cas/native/1.0/IDescrambler.h>
#include <android/hardware/media/omx/1.0/IGraphicBufferSource.h>
#include <binder/IMemory.h>
#include <binder/IPCThreadState.h>
@ -505,7 +506,7 @@ sp<PersistentSurface> MediaCodec::CreatePersistentInputSurface() {
sp<IOMX> omx = client.interface();
sp<IGraphicBufferProducer> bufferProducer;
sp<hardware::media::omx::V1_0::IGraphicBufferSource> bufferSource;
sp<IGraphicBufferSource> bufferSource;
status_t err = omx->createInputSurface(&bufferProducer, &bufferSource);

@ -37,15 +37,6 @@
#define TRACK_BUFFER_TIMING 0
namespace android {
namespace hardware {
namespace media {
namespace omx {
namespace V1_0 {
struct IGraphicBufferSource;
} // namespace V1_0
} // namespace omx
} // namespace media
} // namespace hardware
struct ABuffer;
class ACodecBufferChannel;
@ -288,7 +279,7 @@ private:
size_t mNumUndequeuedBuffers;
sp<DataConverter> mConverter[2];
sp<hardware::media::omx::V1_0::IGraphicBufferSource> mGraphicBufferSource;
sp<IGraphicBufferSource> mGraphicBufferSource;
int64_t mRepeatFrameDelayUs;
int64_t mMaxPtsGapUs;
float mMaxFps;

@ -18,21 +18,31 @@
#define PERSISTENT_SURFACE_H_
#include <android/IGraphicBufferSource.h>
#include <binder/Parcel.h>
#include <hidl/HidlSupport.h>
#include <hidl/HybridInterface.h>
#include <gui/IGraphicBufferProducer.h>
#include <media/stagefright/foundation/ABase.h>
using android::hidl::base::V1_0::IBase;
namespace android {
struct PersistentSurface : public RefBase {
PersistentSurface() {}
// create a persistent surface
// create an OMX persistent surface
PersistentSurface(
const sp<IGraphicBufferProducer>& bufferProducer,
const sp<IGraphicBufferSource>& bufferSource) :
mBufferProducer(bufferProducer),
mBufferSource(bufferSource) { }
// create a HIDL persistent surface
PersistentSurface(
const sp<IGraphicBufferProducer>& bufferProducer,
const sp<hidl::base::V1_0::IBase>& hidlTarget) :
const sp<IBase>& hidlTarget) :
mBufferProducer(bufferProducer),
mHidlTarget(hidlTarget) { }
@ -40,12 +50,18 @@ struct PersistentSurface : public RefBase {
return mBufferProducer;
}
sp<hidl::base::V1_0::IBase> getHidlTarget() const {
sp<IGraphicBufferSource> getBufferSource() const {
return mBufferSource;
}
sp<IBase> getHidlTarget() const {
return mHidlTarget;
}
status_t writeToParcel(Parcel *parcel) const {
parcel->writeStrongBinder(IInterface::asBinder(mBufferProducer));
// this can handle null
parcel->writeStrongBinder(IInterface::asBinder(mBufferSource));
// write hidl target
if (mHidlTarget != nullptr) {
HalToken token;
@ -63,6 +79,8 @@ struct PersistentSurface : public RefBase {
status_t readFromParcel(const Parcel *parcel) {
mBufferProducer = interface_cast<IGraphicBufferProducer>(
parcel->readStrongBinder());
mBufferSource = interface_cast<IGraphicBufferSource>(
parcel->readStrongBinder());
// read hidl target
bool haveHidlTarget = parcel->readBool();
if (haveHidlTarget) {
@ -79,7 +97,8 @@ struct PersistentSurface : public RefBase {
private:
sp<IGraphicBufferProducer> mBufferProducer;
sp<hidl::base::V1_0::IBase> mHidlTarget;
sp<IGraphicBufferSource> mBufferSource;
sp<IBase> mHidlTarget;
DISALLOW_EVIL_CONSTRUCTORS(PersistentSurface);
};

@ -14,10 +14,6 @@
* limitations under the License.
*/
#ifdef __LP64__
#define OMX_ANDROID_COMPILE_AS_32BIT_ON_64BIT_PLATFORMS
#endif
//#define LOG_NDEBUG 0
#define LOG_TAG "TWGraphicBufferSource"
@ -25,7 +21,6 @@
#include <media/stagefright/omx/1.0/WOmxNode.h>
#include <media/stagefright/omx/1.0/Conversion.h>
#include <media/stagefright/omx/OMXUtils.h>
#include <media/stagefright/omx/OmxGraphicBufferSource.h>
#include <android/hardware/media/omx/1.0/IOmxBufferSource.h>
#include <android/hardware/media/omx/1.0/IOmxNode.h>
#include <media/openmax/OMX_Component.h>

@ -14,18 +14,12 @@
* limitations under the License.
*/
#ifdef __LP64__
#define OMX_ANDROID_COMPILE_AS_32BIT_ON_64BIT_PLATFORMS
#endif
#include <inttypes.h>
#define LOG_TAG "OmxGraphicBufferSource"
//#define LOG_NDEBUG 0
#include <utils/Log.h>
#include <media/openmax/OMX_Core.h>
#include <media/stagefright/bqhelper/ComponentWrapper.h>
#include <media/stagefright/bqhelper/GraphicBufferSource.h>
#include <media/stagefright/omx/OmxGraphicBufferSource.h>

@ -48,6 +48,7 @@
#include <android/hardware/media/omx/1.0/IGraphicBufferSource.h>
#include <android/hardware/media/omx/1.0/IOmxObserver.h>
#include <android/IGraphicBufferSource.h>
#include <android/IOMXBufferSource.h>
namespace android {

@ -26,16 +26,18 @@
#include <android/hardware/media/omx/1.0/IOmxNode.h>
#include <android/hardware/media/omx/1.0/IGraphicBufferSource.h>
namespace android {
#include <android/BnGraphicBufferSource.h>
class OmxGraphicBufferSource;
#include <media/stagefright/omx/OmxGraphicBufferSource.h>
namespace android {
namespace hardware {
namespace media {
namespace omx {
namespace V1_0 {
namespace implementation {
using ::android::OmxGraphicBufferSource;
using ::android::hardware::graphics::common::V1_0::Dataspace;
using ::android::hardware::media::omx::V1_0::ColorAspects;
using ::android::hardware::media::omx::V1_0::IGraphicBufferSource;
@ -50,6 +52,8 @@ using ::android::hardware::Return;
using ::android::hardware::Void;
using ::android::sp;
using ::android::IOMXNode;
/**
* Wrapper classes for conversion
* ==============================

@ -21,6 +21,7 @@
#include <media/stagefright/bqhelper/GraphicBufferSource.h>
#include <media/stagefright/foundation/ABase.h>
#include <android/BnGraphicBufferSource.h>
#include <android/BnOMXBufferSource.h>
#include "IOmxNodeWrapper.h"

Loading…
Cancel
Save