Merge "Switch MtpFfsHandle to aio, add control functions."

am: 82651d413e

Change-Id: I622346740d9310c9c9569ed5feb463f51cab6b5e
gugelfrei
Jerry Zhang 7 years ago committed by android-build-merger
commit 68ce743ef9

@ -17,13 +17,13 @@
cc_library_shared {
name: "libmtp",
srcs: [
"AsyncIO.cpp",
"MtpDataPacket.cpp",
"MtpDebug.cpp",
"MtpDevHandle.cpp",
"MtpDevice.cpp",
"MtpDeviceInfo.cpp",
"MtpEventPacket.cpp",
"MtpFfsCompatHandle.cpp",
"MtpFfsHandle.cpp",
"MtpObjectInfo.cpp",
"MtpPacket.cpp",
@ -35,6 +35,7 @@ cc_library_shared {
"MtpStorageInfo.cpp",
"MtpStringBuffer.cpp",
"MtpUtils.cpp",
"PosixAsyncIO.cpp",
],
export_include_dirs: ["."],
cflags: [
@ -45,6 +46,7 @@ cc_library_shared {
"-Werror",
],
shared_libs: [
"libasyncio",
"libbase",
"libutils",
"liblog",

@ -1,182 +0,0 @@
/*
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <android-base/logging.h>
#include <condition_variable>
#include <memory>
#include <mutex>
#include <queue>
#include "AsyncIO.h"
namespace {
void read_func(struct aiocb *aiocbp) {
aiocbp->ret = TEMP_FAILURE_RETRY(pread(aiocbp->aio_fildes,
aiocbp->aio_buf, aiocbp->aio_nbytes, aiocbp->aio_offset));
if (aiocbp->ret == -1) aiocbp->error = errno;
}
void write_func(struct aiocb *aiocbp) {
aiocbp->ret = TEMP_FAILURE_RETRY(pwrite(aiocbp->aio_fildes,
aiocbp->aio_buf, aiocbp->aio_nbytes, aiocbp->aio_offset));
if (aiocbp->ret == -1) aiocbp->error = errno;
}
void splice_read_func(struct aiocb *aiocbp) {
loff_t long_offset = aiocbp->aio_offset;
aiocbp->ret = TEMP_FAILURE_RETRY(splice(aiocbp->aio_fildes,
&long_offset, aiocbp->aio_sink,
NULL, aiocbp->aio_nbytes, 0));
if (aiocbp->ret == -1) aiocbp->error = errno;
}
void splice_write_func(struct aiocb *aiocbp) {
loff_t long_offset = aiocbp->aio_offset;
aiocbp->ret = TEMP_FAILURE_RETRY(splice(aiocbp->aio_fildes, NULL,
aiocbp->aio_sink, &long_offset,
aiocbp->aio_nbytes, 0));
if (aiocbp->ret == -1) aiocbp->error = errno;
}
std::queue<std::unique_ptr<struct aiocb>> queue;
std::mutex queue_lock;
std::condition_variable queue_cond;
std::condition_variable write_cond;
int done = 1;
void splice_write_pool_func(int) {
while(1) {
std::unique_lock<std::mutex> lk(queue_lock);
queue_cond.wait(lk, []{return !queue.empty() || done;});
if (queue.empty() && done) {
return;
}
std::unique_ptr<struct aiocb> aiocbp = std::move(queue.front());
queue.pop();
lk.unlock();
write_cond.notify_one();
splice_write_func(aiocbp.get());
close(aiocbp->aio_fildes);
}
}
void write_pool_func(int) {
while(1) {
std::unique_lock<std::mutex> lk(queue_lock);
queue_cond.wait(lk, []{return !queue.empty() || done;});
if (queue.empty() && done) {
return;
}
std::unique_ptr<struct aiocb> aiocbp = std::move(queue.front());
queue.pop();
lk.unlock();
write_cond.notify_one();
aiocbp->ret = TEMP_FAILURE_RETRY(pwrite(aiocbp->aio_fildes,
aiocbp->aio_pool_buf.get(), aiocbp->aio_nbytes, aiocbp->aio_offset));
if (aiocbp->ret == -1) aiocbp->error = errno;
}
}
constexpr int NUM_THREADS = 1;
constexpr int MAX_QUEUE_SIZE = 10;
std::thread pool[NUM_THREADS];
} // end anonymous namespace
aiocb::~aiocb() {
CHECK(!thread.joinable());
}
void aio_pool_init(void(f)(int)) {
CHECK(done == 1);
done = 0;
for (int i = 0; i < NUM_THREADS; i++) {
pool[i] = std::thread(f, i);
}
}
void aio_pool_splice_init() {
aio_pool_init(splice_write_pool_func);
}
void aio_pool_write_init() {
aio_pool_init(write_pool_func);
}
void aio_pool_end() {
done = 1;
for (int i = 0; i < NUM_THREADS; i++) {
std::unique_lock<std::mutex> lk(queue_lock);
lk.unlock();
queue_cond.notify_one();
}
for (int i = 0; i < NUM_THREADS; i++) {
pool[i].join();
}
}
// used for both writes and splices depending on which init was used before.
int aio_pool_write(struct aiocb *aiocbp) {
std::unique_lock<std::mutex> lk(queue_lock);
write_cond.wait(lk, []{return queue.size() < MAX_QUEUE_SIZE;});
queue.push(std::unique_ptr<struct aiocb>(aiocbp));
lk.unlock();
queue_cond.notify_one();
return 0;
}
int aio_read(struct aiocb *aiocbp) {
aiocbp->thread = std::thread(read_func, aiocbp);
return 0;
}
int aio_write(struct aiocb *aiocbp) {
aiocbp->thread = std::thread(write_func, aiocbp);
return 0;
}
int aio_splice_read(struct aiocb *aiocbp) {
aiocbp->thread = std::thread(splice_read_func, aiocbp);
return 0;
}
int aio_splice_write(struct aiocb *aiocbp) {
aiocbp->thread = std::thread(splice_write_func, aiocbp);
return 0;
}
int aio_error(const struct aiocb *aiocbp) {
return aiocbp->error;
}
ssize_t aio_return(struct aiocb *aiocbp) {
return aiocbp->ret;
}
int aio_suspend(struct aiocb *aiocbp[], int n,
const struct timespec *) {
for (int i = 0; i < n; i++) {
aiocbp[i]->thread.join();
}
return 0;
}
int aio_cancel(int, struct aiocb *) {
// Not implemented
return -1;
}

@ -18,13 +18,13 @@
#include <linux/usb/f_mtp.h>
constexpr char FFS_MTP_EP0[] = "/dev/usb-ffs/mtp/ep0";
namespace android {
class IMtpHandle {
public:
// Return number of bytes read/written, or -1 and errno is set
virtual int read(void *data, int len) = 0;
virtual int write(const void *data, int len) = 0;
virtual int read(void *data, size_t len) = 0;
virtual int write(const void *data, size_t len) = 0;
// Return 0 if send/receive is successful, or -1 and errno is set
virtual int receiveFile(mtp_file_range mfr, bool zero_packet) = 0;
@ -40,8 +40,7 @@ public:
virtual ~IMtpHandle() {}
};
IMtpHandle *get_ffs_handle();
IMtpHandle *get_mtp_handle();
}
#endif // _IMTP_HANDLE_H

@ -20,12 +20,12 @@
#include "MtpPacket.h"
#include "mtp.h"
class IMtpHandle;
struct usb_device;
struct usb_request;
namespace android {
class IMtpHandle;
class MtpStringBuffer;
class MtpDataPacket : public MtpPacket {

@ -14,57 +14,37 @@
* limitations under the License.
*/
#include <utils/Log.h>
#include <fcntl.h>
#include <sys/stat.h>
#include <android-base/logging.h>
#include <cutils/properties.h>
#include <dirent.h>
#include <errno.h>
#include <fcntl.h>
#include <linux/usb/ch9.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
#include <sys/ioctl.h>
#include <sys/types.h>
#include <sys/endian.h>
#include <unistd.h>
#include <android-base/logging.h>
#include <android-base/unique_fd.h>
#include "IMtpHandle.h"
#include "MtpDevHandle.h"
constexpr char mtp_dev_path[] = "/dev/mtp_usb";
namespace android {
class MtpDevHandle : public IMtpHandle {
private:
android::base::unique_fd mFd;
public:
MtpDevHandle();
~MtpDevHandle();
int read(void *data, int len);
int write(const void *data, int len);
int receiveFile(mtp_file_range mfr, bool);
int sendFile(mtp_file_range mfr);
int sendEvent(mtp_event me);
int start();
void close();
int configure(bool ptp);
};
constexpr char mtp_dev_path[] = "/dev/mtp_usb";
MtpDevHandle::MtpDevHandle()
: mFd(-1) {};
MtpDevHandle::~MtpDevHandle() {}
int MtpDevHandle::read(void *data, int len) {
int MtpDevHandle::read(void *data, size_t len) {
return ::read(mFd, data, len);
}
int MtpDevHandle::write(const void *data, int len) {
int MtpDevHandle::write(const void *data, size_t len) {
return ::write(mFd, data, len);
}
@ -81,7 +61,7 @@ int MtpDevHandle::sendEvent(mtp_event me) {
}
int MtpDevHandle::start() {
mFd = android::base::unique_fd(TEMP_FAILURE_RETRY(open(mtp_dev_path, O_RDWR)));
mFd.reset(TEMP_FAILURE_RETRY(open(mtp_dev_path, O_RDWR)));
if (mFd == -1) return -1;
return 0;
}
@ -95,6 +75,4 @@ int MtpDevHandle::configure(bool) {
return 0;
}
IMtpHandle *get_mtp_handle() {
return new MtpDevHandle();
}
} // namespace android

@ -0,0 +1,47 @@
/*
* Copyright (C) 2017 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef _MTP_DEV_HANDLE_H
#define _MTP_DEV_HANDLE_H
#include <android-base/unique_fd.h>
#include "IMtpHandle.h"
namespace android {
class MtpDevHandle : public IMtpHandle {
private:
android::base::unique_fd mFd;
public:
MtpDevHandle();
~MtpDevHandle();
int read(void *data, size_t len);
int write(const void *data, size_t len);
int receiveFile(mtp_file_range mfr, bool);
int sendFile(mtp_file_range mfr);
int sendEvent(mtp_event me);
int start();
void close();
int configure(bool ptp);
};
} // namespace android
#endif // _MTP_FFS_HANDLE_H

@ -0,0 +1,342 @@
/*
* Copyright (C) 2017 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <android-base/logging.h>
#include <android-base/properties.h>
#include <dirent.h>
#include <errno.h>
#include <fcntl.h>
#include <linux/usb/ch9.h>
#include <linux/usb/functionfs.h>
#include <mutex>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/endian.h>
#include <sys/ioctl.h>
#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <unistd.h>
#include "PosixAsyncIO.h"
#include "MtpFfsCompatHandle.h"
#include "mtp.h"
#define FUNCTIONFS_ENDPOINT_ALLOC _IOR('g', 231, __u32)
namespace {
// Must be divisible by all max packet size values
constexpr int MAX_FILE_CHUNK_SIZE = 3145728;
// Safe values since some devices cannot handle large DMAs
// To get good performance, override these with
// higher values per device using the properties
// sys.usb.ffs.max_read and sys.usb.ffs.max_write
constexpr int USB_FFS_MAX_WRITE = MTP_BUFFER_SIZE;
constexpr int USB_FFS_MAX_READ = MTP_BUFFER_SIZE;
static_assert(USB_FFS_MAX_WRITE > 0, "Max r/w values must be > 0!");
static_assert(USB_FFS_MAX_READ > 0, "Max r/w values must be > 0!");
constexpr unsigned int MAX_MTP_FILE_SIZE = 0xFFFFFFFF;
constexpr size_t ENDPOINT_ALLOC_RETRIES = 10;
} // anonymous namespace
namespace android {
MtpFfsCompatHandle::MtpFfsCompatHandle() :
mMaxWrite(USB_FFS_MAX_WRITE),
mMaxRead(USB_FFS_MAX_READ) {}
MtpFfsCompatHandle::~MtpFfsCompatHandle() {}
int MtpFfsCompatHandle::writeHandle(int fd, const void* data, size_t len) {
int ret = 0;
const char* buf = static_cast<const char*>(data);
while (len > 0) {
int write_len = std::min(mMaxWrite, len);
int n = TEMP_FAILURE_RETRY(::write(fd, buf, write_len));
if (n < 0) {
PLOG(ERROR) << "write ERROR: fd = " << fd << ", n = " << n;
return -1;
} else if (n < write_len) {
errno = EIO;
PLOG(ERROR) << "less written than expected";
return -1;
}
buf += n;
len -= n;
ret += n;
}
return ret;
}
int MtpFfsCompatHandle::readHandle(int fd, void* data, size_t len) {
int ret = 0;
char* buf = static_cast<char*>(data);
while (len > 0) {
int read_len = std::min(mMaxRead, len);
int n = TEMP_FAILURE_RETRY(::read(fd, buf, read_len));
if (n < 0) {
PLOG(ERROR) << "read ERROR: fd = " << fd << ", n = " << n;
return -1;
}
ret += n;
if (n < read_len) // done reading early
break;
buf += n;
len -= n;
}
return ret;
}
int MtpFfsCompatHandle::start() {
mLock.lock();
if (!openEndpoints())
return -1;
for (unsigned i = 0; i < NUM_IO_BUFS; i++) {
mIobuf[i].bufs.resize(MAX_FILE_CHUNK_SIZE);
posix_madvise(mIobuf[i].bufs.data(), MAX_FILE_CHUNK_SIZE,
POSIX_MADV_SEQUENTIAL | POSIX_MADV_WILLNEED);
}
// Get device specific r/w size
mMaxWrite = android::base::GetIntProperty("sys.usb.ffs.max_write", USB_FFS_MAX_WRITE);
mMaxRead = android::base::GetIntProperty("sys.usb.ffs.max_read", USB_FFS_MAX_READ);
size_t attempts = 0;
while (mMaxWrite >= USB_FFS_MAX_WRITE && mMaxRead >= USB_FFS_MAX_READ &&
attempts < ENDPOINT_ALLOC_RETRIES) {
// If larger contiguous chunks of memory aren't available, attempt to try
// smaller allocations.
if (ioctl(mBulkIn, FUNCTIONFS_ENDPOINT_ALLOC, static_cast<__u32>(mMaxWrite)) ||
ioctl(mBulkOut, FUNCTIONFS_ENDPOINT_ALLOC, static_cast<__u32>(mMaxRead))) {
if (errno == ENODEV) {
// Driver hasn't enabled endpoints yet.
std::this_thread::sleep_for(std::chrono::milliseconds(100));
attempts += 1;
continue;
}
mMaxWrite /= 2;
mMaxRead /=2;
} else {
return 0;
}
}
// Try to start MtpServer anyway, with the smallest max r/w values
mMaxWrite = USB_FFS_MAX_WRITE;
mMaxRead = USB_FFS_MAX_READ;
PLOG(ERROR) << "Functionfs could not allocate any memory!";
return 0;
}
int MtpFfsCompatHandle::read(void* data, size_t len) {
return readHandle(mBulkOut, data, len);
}
int MtpFfsCompatHandle::write(const void* data, size_t len) {
return writeHandle(mBulkIn, data, len);
}
int MtpFfsCompatHandle::receiveFile(mtp_file_range mfr, bool zero_packet) {
// When receiving files, the incoming length is given in 32 bits.
// A >4G file is given as 0xFFFFFFFF
uint32_t file_length = mfr.length;
uint64_t offset = mfr.offset;
int packet_size = getPacketSize(mBulkOut);
unsigned char *data = mIobuf[0].bufs.data();
unsigned char *data2 = mIobuf[1].bufs.data();
struct aiocb aio;
aio.aio_fildes = mfr.fd;
aio.aio_buf = nullptr;
struct aiocb *aiol[] = {&aio};
int ret = -1;
size_t length;
bool read = false;
bool write = false;
posix_fadvise(mfr.fd, 0, 0, POSIX_FADV_SEQUENTIAL | POSIX_FADV_NOREUSE);
// Break down the file into pieces that fit in buffers
while (file_length > 0 || write) {
if (file_length > 0) {
length = std::min(static_cast<uint32_t>(MAX_FILE_CHUNK_SIZE), file_length);
// Read data from USB, handle errors after waiting for write thread.
ret = readHandle(mBulkOut, data, length);
if (file_length != MAX_MTP_FILE_SIZE && ret < static_cast<int>(length)) {
ret = -1;
errno = EIO;
}
read = true;
}
if (write) {
// get the return status of the last write request
aio_suspend(aiol, 1, nullptr);
int written = aio_return(&aio);
if (written == -1) {
errno = aio_error(&aio);
return -1;
}
if (static_cast<size_t>(written) < aio.aio_nbytes) {
errno = EIO;
return -1;
}
write = false;
}
// If there was an error reading above
if (ret == -1) {
return -1;
}
if (read) {
if (file_length == MAX_MTP_FILE_SIZE) {
// For larger files, receive until a short packet is received.
if (static_cast<size_t>(ret) < length) {
file_length = 0;
}
} else {
file_length -= ret;
}
// Enqueue a new write request
aio_prepare(&aio, data, length, offset);
aio_write(&aio);
offset += ret;
std::swap(data, data2);
write = true;
read = false;
}
}
// Receive an empty packet if size is a multiple of the endpoint size.
if (ret % packet_size == 0 || zero_packet) {
if (TEMP_FAILURE_RETRY(::read(mBulkOut, data, packet_size)) != 0) {
return -1;
}
}
return 0;
}
int MtpFfsCompatHandle::sendFile(mtp_file_range mfr) {
uint64_t file_length = mfr.length;
uint32_t given_length = std::min(static_cast<uint64_t>(MAX_MTP_FILE_SIZE),
file_length + sizeof(mtp_data_header));
uint64_t offset = mfr.offset;
int packet_size = getPacketSize(mBulkIn);
// If file_length is larger than a size_t, truncating would produce the wrong comparison.
// Instead, promote the left side to 64 bits, then truncate the small result.
int init_read_len = std::min(
static_cast<uint64_t>(packet_size - sizeof(mtp_data_header)), file_length);
unsigned char *data = mIobuf[0].bufs.data();
unsigned char *data2 = mIobuf[1].bufs.data();
posix_fadvise(mfr.fd, 0, 0, POSIX_FADV_SEQUENTIAL | POSIX_FADV_NOREUSE);
struct aiocb aio;
aio.aio_fildes = mfr.fd;
struct aiocb *aiol[] = {&aio};
int ret, length;
int error = 0;
bool read = false;
bool write = false;
// Send the header data
mtp_data_header *header = reinterpret_cast<mtp_data_header*>(data);
header->length = htole32(given_length);
header->type = htole16(2); /* data packet */
header->command = htole16(mfr.command);
header->transaction_id = htole32(mfr.transaction_id);
// Some hosts don't support header/data separation even though MTP allows it
// Handle by filling first packet with initial file data
if (TEMP_FAILURE_RETRY(pread(mfr.fd, reinterpret_cast<char*>(data) +
sizeof(mtp_data_header), init_read_len, offset))
!= init_read_len) return -1;
if (writeHandle(mBulkIn, data, sizeof(mtp_data_header) + init_read_len) == -1) return -1;
file_length -= init_read_len;
offset += init_read_len;
ret = init_read_len + sizeof(mtp_data_header);
// Break down the file into pieces that fit in buffers
while (file_length > 0) {
if (read) {
// Wait for the previous read to finish
aio_suspend(aiol, 1, nullptr);
ret = aio_return(&aio);
if (ret == -1) {
errno = aio_error(&aio);
return -1;
}
if (static_cast<size_t>(ret) < aio.aio_nbytes) {
errno = EIO;
return -1;
}
file_length -= ret;
offset += ret;
std::swap(data, data2);
read = false;
write = true;
}
if (error == -1) {
return -1;
}
if (file_length > 0) {
length = std::min(static_cast<uint64_t>(MAX_FILE_CHUNK_SIZE), file_length);
// Queue up another read
aio_prepare(&aio, data, length, offset);
aio_read(&aio);
read = true;
}
if (write) {
if (writeHandle(mBulkIn, data2, ret) == -1) {
error = -1;
}
write = false;
}
}
if (ret % packet_size == 0) {
// If the last packet wasn't short, send a final empty packet
if (TEMP_FAILURE_RETRY(::write(mBulkIn, data, 0)) != 0) {
return -1;
}
}
return 0;
}
} // namespace android

@ -0,0 +1,54 @@
/*
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef _MTP_FFS_COMPAT_HANDLE_H
#define _MTP_FFS_COMPAT_HANDLE_H
#include <MtpFfsHandle.h>
namespace android {
template <class T> class MtpFfsHandleTest;
class MtpFfsCompatHandle : public MtpFfsHandle {
template <class T> friend class android::MtpFfsHandleTest;
private:
int writeHandle(int fd, const void *data, size_t len);
int readHandle(int fd, void *data, size_t len);
size_t mMaxWrite;
size_t mMaxRead;
public:
int read(void* data, size_t len) override;
int write(const void* data, size_t len) override;
int receiveFile(mtp_file_range mfr, bool zero_packet) override;
int sendFile(mtp_file_range mfr) override;
/**
* Open ffs endpoints and allocate necessary kernel and user memory.
* Will sleep until endpoints are enabled, for up to 1 second.
*/
int start() override;
MtpFfsCompatHandle();
~MtpFfsCompatHandle();
};
} // namespace android
#endif // _MTP_FFS_COMPAT_HANDLE_H

File diff suppressed because it is too large Load Diff

@ -18,26 +18,51 @@
#define _MTP_FFS_HANDLE_H
#include <android-base/unique_fd.h>
#include <linux/aio_abi.h>
#include <mutex>
#include <sys/poll.h>
#include <time.h>
#include <thread>
#include <vector>
#include <IMtpHandle.h>
namespace android {
class MtpFfsHandleTest;
constexpr char FFS_MTP_EP0[] = "/dev/usb-ffs/mtp/ep0";
constexpr int NUM_IO_BUFS = 2;
struct io_buffer {
std::vector<struct iocb> iocbs; // Holds memory for all iocbs. Not used directly.
std::vector<struct iocb*> iocb; // Pointers to individual iocbs, for syscalls
std::vector<unsigned char> bufs; // A large buffer, used with filesystem io
std::vector<unsigned char*> buf; // Pointers within the larger buffer, for syscalls
unsigned actual; // The number of buffers submitted for this request
};
template <class T> class MtpFfsHandleTest;
class MtpFfsHandle : public IMtpHandle {
friend class android::MtpFfsHandleTest;
private:
int writeHandle(int fd, const void *data, int len);
int readHandle(int fd, void *data, int len);
int spliceReadHandle(int fd, int fd_out, int len);
template <class T> friend class android::MtpFfsHandleTest;
protected:
bool initFunctionfs();
void closeConfig();
void closeEndpoints();
void advise(int fd);
int handleControlRequest(const struct usb_ctrlrequest *request);
int doAsync(void* data, size_t len, bool read);
int handleEvent();
void cancelTransaction();
void doSendEvent(mtp_event me);
bool openEndpoints();
static int getPacketSize(int ffs_fd);
bool mPtp;
bool mCanceled;
std::timed_mutex mLock;
std::timed_mutex mLock; // protects configure() vs main loop
android::base::unique_fd mControl;
// "in" from the host's perspective => sink for mtp server
@ -46,28 +71,35 @@ private:
android::base::unique_fd mBulkOut;
android::base::unique_fd mIntr;
int mMaxWrite;
int mMaxRead;
aio_context_t mCtx;
android::base::unique_fd mEventFd;
struct pollfd mPollFds[2];
struct io_buffer mIobuf[NUM_IO_BUFS];
// Submit an io request of given length. Return amount submitted or -1.
int iobufSubmit(struct io_buffer *buf, int fd, unsigned length, bool read);
// Cancel submitted requests from start to end in the given array. Return 0 or -1.
int cancelEvents(struct iocb **iocb, struct io_event *events, unsigned start, unsigned end);
std::vector<char> mBuffer1;
std::vector<char> mBuffer2;
// Wait for at minimum the given number of events. Returns the amount of data in the returned
// events. Increments counter by the number of events returned.
int waitEvents(struct io_buffer *buf, int min_events, struct io_event *events, int *counter);
public:
int read(void *data, int len);
int write(const void *data, int len);
int read(void *data, size_t len) override;
int write(const void *data, size_t len) override;
int receiveFile(mtp_file_range mfr, bool zero_packet);
int sendFile(mtp_file_range mfr);
int sendEvent(mtp_event me);
int receiveFile(mtp_file_range mfr, bool zero_packet) override;
int sendFile(mtp_file_range mfr) override;
int sendEvent(mtp_event me) override;
/**
* Open ffs endpoints and allocate necessary kernel and user memory.
* Will sleep until endpoints are enabled, for up to 1 second.
*/
int start();
void close();
int start() override;
void close() override;
int configure(bool ptp);
int configure(bool ptp) override;
MtpFfsHandle();
~MtpFfsHandle();
@ -86,5 +118,5 @@ struct mtp_data_header {
} // namespace android
#endif // _MTP_FF_HANDLE_H
#endif // _MTP_FFS_HANDLE_H

@ -31,6 +31,9 @@
#include "MtpDebug.h"
#include "MtpDatabase.h"
#include "MtpDevHandle.h"
#include "MtpFfsCompatHandle.h"
#include "MtpFfsHandle.h"
#include "MtpObjectInfo.h"
#include "MtpProperty.h"
#include "MtpServer.h"
@ -125,16 +128,21 @@ MtpServer::~MtpServer() {
IMtpHandle* MtpServer::sHandle = nullptr;
int MtpServer::configure(bool usePtp) {
bool ffs_ok = access(FFS_MTP_EP0, W_OK) == 0;
if (sHandle == nullptr) {
bool ffs_ok = access(FFS_MTP_EP0, W_OK) == 0;
sHandle = ffs_ok ? get_ffs_handle() : get_mtp_handle();
if (ffs_ok) {
bool aio_compat = android::base::GetBoolProperty("sys.usb.ffs.aio_compat", false);
sHandle = aio_compat ? new MtpFfsCompatHandle() : new MtpFfsHandle();
} else {
sHandle = new MtpDevHandle();
}
}
int ret = sHandle->configure(usePtp);
if (ret) ALOGE("Failed to configure MTP driver!");
else android::base::SetProperty("sys.usb.ffs.mtp.ready", "1");
return ret;
if (sHandle->configure(usePtp)) {
ALOGE("Failed to configure Mtp driver!");
return -1;
}
android::base::SetProperty("sys.usb.ffs.mtp.ready", "1");
return 0;
}
void MtpServer::addStorage(MtpStorage* storage) {
@ -878,6 +886,7 @@ MtpResponseCode MtpServer::doGetPartialObject(MtpOperationCode operation) {
length = fileLength - offset;
const char* filePath = (const char *)pathBuf;
ALOGV("sending partial %s %" PRIu64 " %" PRIu32, filePath, offset, length);
mtp_file_range mfr;
mfr.fd = open(filePath, O_RDONLY);
if (mfr.fd < 0) {

@ -0,0 +1,76 @@
/*
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <android-base/logging.h>
#include <condition_variable>
#include <memory>
#include <mutex>
#include <queue>
#include <unistd.h>
#include "PosixAsyncIO.h"
namespace {
void read_func(struct aiocb *aiocbp) {
aiocbp->ret = TEMP_FAILURE_RETRY(pread(aiocbp->aio_fildes,
aiocbp->aio_buf, aiocbp->aio_nbytes, aiocbp->aio_offset));
if (aiocbp->ret == -1) aiocbp->error = errno;
}
void write_func(struct aiocb *aiocbp) {
aiocbp->ret = TEMP_FAILURE_RETRY(pwrite(aiocbp->aio_fildes,
aiocbp->aio_buf, aiocbp->aio_nbytes, aiocbp->aio_offset));
if (aiocbp->ret == -1) aiocbp->error = errno;
}
} // end anonymous namespace
aiocb::~aiocb() {
CHECK(!thread.joinable());
}
int aio_read(struct aiocb *aiocbp) {
aiocbp->thread = std::thread(read_func, aiocbp);
return 0;
}
int aio_write(struct aiocb *aiocbp) {
aiocbp->thread = std::thread(write_func, aiocbp);
return 0;
}
int aio_error(const struct aiocb *aiocbp) {
return aiocbp->error;
}
ssize_t aio_return(struct aiocb *aiocbp) {
return aiocbp->ret;
}
int aio_suspend(struct aiocb *aiocbp[], int n,
const struct timespec *) {
for (int i = 0; i < n; i++) {
aiocbp[i]->thread.join();
}
return 0;
}
void aio_prepare(struct aiocb *aiocbp, void* buf, size_t count, off_t offset) {
aiocbp->aio_buf = buf;
aiocbp->aio_offset = offset;
aiocbp->aio_nbytes = count;
}

@ -14,13 +14,9 @@
* limitations under the License.
*/
#ifndef _ASYNCIO_H
#define _ASYNCIO_H
#ifndef _POSIXASYNCIO_H
#define _POSIXASYNCIO_H
#include <fcntl.h>
#include <linux/aio_abi.h>
#include <memory>
#include <signal.h>
#include <sys/cdefs.h>
#include <sys/types.h>
#include <time.h>
@ -28,22 +24,16 @@
#include <unistd.h>
/**
* Provides a subset of POSIX aio operations, as well
* as similar operations with splice and threadpools.
* Provides a subset of POSIX aio operations.
*/
struct aiocb {
int aio_fildes; // Assumed to be the source for splices
void *aio_buf; // Unused for splices
// Used for threadpool operations only, freed automatically
std::unique_ptr<char[]> aio_pool_buf;
int aio_fildes;
void *aio_buf;
off_t aio_offset;
size_t aio_nbytes;
int aio_sink; // Unused for non splice r/w
// Used internally
std::thread thread;
ssize_t ret;
@ -55,8 +45,6 @@ struct aiocb {
// Submit a request for IO to be completed
int aio_read(struct aiocb *);
int aio_write(struct aiocb *);
int aio_splice_read(struct aiocb *);
int aio_splice_write(struct aiocb *);
// Suspend current thread until given IO is complete, at which point
// its return value and any errors can be accessed
@ -66,18 +54,8 @@ int aio_suspend(struct aiocb *[], int, const struct timespec *);
int aio_error(const struct aiocb *);
ssize_t aio_return(struct aiocb *);
// (Currently unimplemented)
int aio_cancel(int, struct aiocb *);
// Initialize a threadpool to perform IO. Only one pool can be
// running at a time.
void aio_pool_write_init();
void aio_pool_splice_init();
// Suspend current thread until all queued work is complete, then ends the threadpool
void aio_pool_end();
// Submit IO work for the threadpool to complete. Memory associated with the work is
// freed automatically when the work is complete.
int aio_pool_write(struct aiocb *);
// Helper method for setting aiocb members
void aio_prepare(struct aiocb *, void*, size_t, off_t);
#endif // ASYNCIO_H
#endif // POSIXASYNCIO_H

@ -493,4 +493,10 @@
#define MTP_ASSOCIATION_TYPE_UNDEFINED 0x0000
#define MTP_ASSOCIATION_TYPE_GENERIC_FOLDER 0x0001
// MTP class reqeusts
#define MTP_REQ_CANCEL 0x64
#define MTP_REQ_GET_EXT_EVENT_DATA 0x65
#define MTP_REQ_RESET 0x66
#define MTP_REQ_GET_DEVICE_STATUS 0x67
#endif // _MTP_H

@ -31,8 +31,9 @@ cc_test {
}
cc_test {
name: "async_io_test",
srcs: ["AsyncIO_test.cpp"],
name: "posix_async_io_test",
test_suites: ["device-tests"],
srcs: ["PosixAsyncIO_test.cpp"],
shared_libs: [
"libbase",
"libmtp",

@ -1,192 +0,0 @@
/*
* Copyright 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#define LOG_TAG "AsyncIO_test.cpp"
#include <android-base/test_utils.h>
#include <fcntl.h>
#include <gtest/gtest.h>
#include <string>
#include <unistd.h>
#include <utils/Log.h>
#include "AsyncIO.h"
namespace android {
constexpr int TEST_PACKET_SIZE = 512;
constexpr int POOL_COUNT = 10;
static const std::string dummyDataStr =
"/*\n * Copyright 2015 The Android Open Source Project\n *\n * Licensed un"
"der the Apache License, Version 2.0 (the \"License\");\n * you may not us"
"e this file except in compliance with the License.\n * You may obtain a c"
"opy of the License at\n *\n * http://www.apache.org/licenses/LICENSE"
"-2.0\n *\n * Unless required by applicable law or agreed to in writing, s"
"oftware\n * distributed under the License is distributed on an \"AS IS\" "
"BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express o"
"r implied.\n * Se";
class AsyncIOTest : public ::testing::Test {
protected:
TemporaryFile dummy_file;
AsyncIOTest() {}
~AsyncIOTest() {}
};
TEST_F(AsyncIOTest, testRead) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
EXPECT_EQ(write(dummy_file.fd, dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = dummy_file.fd;
aio.aio_buf = buf;
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_read(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(AsyncIOTest, testWrite) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = dummy_file.fd;
aio.aio_buf = const_cast<char*>(dummyDataStr.c_str());
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_write(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), TEST_PACKET_SIZE);
EXPECT_EQ(read(dummy_file.fd, buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(AsyncIOTest, testError) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = -1;
aio.aio_buf = const_cast<char*>(dummyDataStr.c_str());
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_write(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), -1);
EXPECT_EQ(aio_error(&aio), EBADF);
}
TEST_F(AsyncIOTest, testSpliceRead) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
int pipeFd[2];
EXPECT_EQ(pipe(pipeFd), 0);
EXPECT_EQ(write(dummy_file.fd, dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = dummy_file.fd;
aio.aio_sink = pipeFd[1];
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_splice_read(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), TEST_PACKET_SIZE);
EXPECT_EQ(read(pipeFd[0], buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(AsyncIOTest, testSpliceWrite) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
int pipeFd[2];
EXPECT_EQ(pipe(pipeFd), 0);
EXPECT_EQ(write(pipeFd[1], dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = pipeFd[0];
aio.aio_sink = dummy_file.fd;
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_splice_write(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), TEST_PACKET_SIZE);
EXPECT_EQ(read(dummy_file.fd, buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(AsyncIOTest, testPoolWrite) {
aio_pool_write_init();
char buf[TEST_PACKET_SIZE * POOL_COUNT + 1];
buf[TEST_PACKET_SIZE * POOL_COUNT] = '\0';
for (int i = 0; i < POOL_COUNT; i++) {
struct aiocb *aiop = new struct aiocb;
aiop->aio_fildes = dummy_file.fd;
aiop->aio_pool_buf = std::unique_ptr<char[]>(new char[TEST_PACKET_SIZE]);
memcpy(aiop->aio_pool_buf.get(), dummyDataStr.c_str(), TEST_PACKET_SIZE);
aiop->aio_offset = i * TEST_PACKET_SIZE;
aiop->aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_pool_write(aiop), 0);
}
aio_pool_end();
EXPECT_EQ(read(dummy_file.fd, buf, TEST_PACKET_SIZE * POOL_COUNT), TEST_PACKET_SIZE * POOL_COUNT);
std::stringstream ss;
for (int i = 0; i < POOL_COUNT; i++)
ss << dummyDataStr;
EXPECT_STREQ(buf, ss.str().c_str());
}
TEST_F(AsyncIOTest, testSplicePoolWrite) {
aio_pool_splice_init();
char buf[TEST_PACKET_SIZE * POOL_COUNT + 1];
buf[TEST_PACKET_SIZE * POOL_COUNT] = '\0';
for (int i = 0; i < POOL_COUNT; i++) {
int pipeFd[2];
EXPECT_EQ(pipe(pipeFd), 0);
EXPECT_EQ(write(pipeFd[1], dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
struct aiocb *aiop = new struct aiocb;
aiop->aio_fildes = pipeFd[0];
aiop->aio_sink = dummy_file.fd;
aiop->aio_offset = i * TEST_PACKET_SIZE;
aiop->aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_pool_write(aiop), 0);
}
aio_pool_end();
EXPECT_EQ(read(dummy_file.fd, buf, TEST_PACKET_SIZE * POOL_COUNT), TEST_PACKET_SIZE * POOL_COUNT);
std::stringstream ss;
for (int i = 0; i < POOL_COUNT; i++)
ss << dummyDataStr;
EXPECT_STREQ(buf, ss.str().c_str());
}
} // namespace android

@ -26,12 +26,11 @@
#include <utils/Log.h>
#include "MtpFfsHandle.h"
#include "MtpFfsCompatHandle.h"
namespace android {
constexpr int MAX_FILE_CHUNK_SIZE = 3 * 1024 * 1024;
constexpr int TEST_PACKET_SIZE = 512;
constexpr int TEST_PACKET_SIZE = 500;
constexpr int SMALL_MULT = 30;
constexpr int MED_MULT = 510;
@ -43,17 +42,19 @@ static const std::string dummyDataStr =
"-2.0\n *\n * Unless required by applicable law or agreed to in writing, s"
"oftware\n * distributed under the License is distributed on an \"AS IS\" "
"BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express o"
"r implied.\n * Se";
"r im";
/**
* Functional tests for the MtpFfsHandle class. Ensures header and data integrity
* by mocking ffs endpoints as pipes to capture input / output.
*/
template <class T>
class MtpFfsHandleTest : public ::testing::Test {
protected:
std::unique_ptr<IMtpHandle> handle;
std::unique_ptr<MtpFfsHandle> handle;
// Pipes for reading endpoint data
android::base::unique_fd control;
android::base::unique_fd bulk_in;
android::base::unique_fd bulk_out;
android::base::unique_fd intr;
@ -62,88 +63,144 @@ protected:
MtpFfsHandleTest() {
int fd[2];
handle = std::unique_ptr<IMtpHandle>(get_ffs_handle());
MtpFfsHandle *ffs_handle = static_cast<MtpFfsHandle*>(handle.get());
EXPECT_TRUE(ffs_handle != NULL);
handle = std::make_unique<T>();
EXPECT_EQ(pipe(fd), 0);
handle->mControl.reset(fd[0]);
control.reset(fd[1]);
EXPECT_EQ(pipe(fd), 0);
EXPECT_EQ(fcntl(fd[0], F_SETPIPE_SZ, 1048576), 1048576);
bulk_in.reset(fd[0]);
ffs_handle->mBulkIn.reset(fd[1]);
handle->mBulkIn.reset(fd[1]);
EXPECT_EQ(pipe(fd), 0);
EXPECT_EQ(fcntl(fd[0], F_SETPIPE_SZ, 1048576), 1048576);
bulk_out.reset(fd[1]);
ffs_handle->mBulkOut.reset(fd[0]);
handle->mBulkOut.reset(fd[0]);
EXPECT_EQ(pipe(fd), 0);
intr.reset(fd[0]);
ffs_handle->mIntr.reset(fd[1]);
handle->mIntr.reset(fd[1]);
ffs_handle->mBuffer1.resize(MAX_FILE_CHUNK_SIZE);
ffs_handle->mBuffer2.resize(MAX_FILE_CHUNK_SIZE);
handle->start();
}
~MtpFfsHandleTest() {}
~MtpFfsHandleTest() {
handle->close();
}
};
TEST_F(MtpFfsHandleTest, testRead) {
EXPECT_EQ(write(bulk_out, dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
typedef ::testing::Types<MtpFfsHandle, MtpFfsCompatHandle> mtpHandles;
TYPED_TEST_CASE(MtpFfsHandleTest, mtpHandles);
TYPED_TEST(MtpFfsHandleTest, testRead) {
EXPECT_EQ(write(this->bulk_out, dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
EXPECT_EQ(handle->read(buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_EQ(this->handle->read(buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(MtpFfsHandleTest, testWrite) {
TYPED_TEST(MtpFfsHandleTest, testWrite) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
EXPECT_EQ(handle->write(dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_EQ(read(bulk_in, buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_EQ(this->handle->write(dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_EQ(read(this->bulk_in, buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(MtpFfsHandleTest, testReceiveFileSmall) {
TYPED_TEST(MtpFfsHandleTest, testReceiveFileEmpty) {
std::stringstream ss;
mtp_file_range mfr;
int size = 0;
char buf[size + 1];
buf[size] = '\0';
mfr.offset = 0;
mfr.length = size;
mfr.fd = this->dummy_file.fd;
EXPECT_EQ(write(this->bulk_out, ss.str().c_str(), size), size);
EXPECT_EQ(this->handle->receiveFile(mfr, false), 0);
EXPECT_EQ(read(this->dummy_file.fd, buf, size), size);
}
TYPED_TEST(MtpFfsHandleTest, testReceiveFileSmall) {
std::stringstream ss;
mtp_file_range mfr;
int size = TEST_PACKET_SIZE * SMALL_MULT;
char buf[size + 1];
buf[size] = '\0';
mfr.offset = 0;
mfr.length = size;
mfr.fd = dummy_file.fd;
mfr.fd = this->dummy_file.fd;
for (int i = 0; i < SMALL_MULT; i++)
ss << dummyDataStr;
EXPECT_EQ(write(bulk_out, ss.str().c_str(), size), size);
EXPECT_EQ(handle->receiveFile(mfr, false), 0);
EXPECT_EQ(write(this->bulk_out, ss.str().c_str(), size), size);
EXPECT_EQ(this->handle->receiveFile(mfr, false), 0);
EXPECT_EQ(read(dummy_file.fd, buf, size), size);
EXPECT_EQ(read(this->dummy_file.fd, buf, size), size);
EXPECT_STREQ(buf, ss.str().c_str());
}
TEST_F(MtpFfsHandleTest, testReceiveFileMed) {
TYPED_TEST(MtpFfsHandleTest, testReceiveFileMed) {
std::stringstream ss;
mtp_file_range mfr;
int size = TEST_PACKET_SIZE * MED_MULT;
char buf[size + 1];
buf[size] = '\0';
mfr.offset = 0;
mfr.length = size;
mfr.fd = dummy_file.fd;
mfr.fd = this->dummy_file.fd;
for (int i = 0; i < MED_MULT; i++)
ss << dummyDataStr;
EXPECT_EQ(write(bulk_out, ss.str().c_str(), size), size);
EXPECT_EQ(handle->receiveFile(mfr, false), 0);
EXPECT_EQ(write(this->bulk_out, ss.str().c_str(), size), size);
EXPECT_EQ(this->handle->receiveFile(mfr, false), 0);
EXPECT_EQ(read(this->dummy_file.fd, buf, size), size);
EXPECT_STREQ(buf, ss.str().c_str());
}
TYPED_TEST(MtpFfsHandleTest, testReceiveFileMedPartial) {
std::stringstream ss;
mtp_file_range mfr;
int size = TEST_PACKET_SIZE * MED_MULT;
char buf[size + 1];
buf[size] = '\0';
mfr.fd = this->dummy_file.fd;
for (int i = 0; i < MED_MULT; i++)
ss << dummyDataStr;
EXPECT_EQ(write(this->bulk_out, ss.str().c_str(), size), size);
std::random_device rd;
std::mt19937 gen(rd());
std::uniform_int_distribution<> dis(1, TEST_PACKET_SIZE);
int offset = 0;
while (offset != size) {
mfr.offset = offset;
int length = std::min(size - offset, dis(gen));
mfr.length = length;
EXPECT_EQ(this->handle->receiveFile(mfr, false), 0);
offset += length;
}
EXPECT_EQ(read(dummy_file.fd, buf, size), size);
EXPECT_EQ(read(this->dummy_file.fd, buf, size), size);
EXPECT_STREQ(buf, ss.str().c_str());
}
TEST_F(MtpFfsHandleTest, testSendFileSmall) {
TYPED_TEST(MtpFfsHandleTest, testSendFileSmall) {
std::stringstream ss;
mtp_file_range mfr;
mfr.command = 42;
@ -154,14 +211,14 @@ TEST_F(MtpFfsHandleTest, testSendFileSmall) {
buf[size + sizeof(mtp_data_header)] = '\0';
mfr.length = size;
mfr.fd = dummy_file.fd;
mfr.fd = this->dummy_file.fd;
for (int i = 0; i < SMALL_MULT; i++)
ss << dummyDataStr;
EXPECT_EQ(write(dummy_file.fd, ss.str().c_str(), size), size);
EXPECT_EQ(handle->sendFile(mfr), 0);
EXPECT_EQ(write(this->dummy_file.fd, ss.str().c_str(), size), size);
EXPECT_EQ(this->handle->sendFile(mfr), 0);
EXPECT_EQ(read(bulk_in, buf, size + sizeof(mtp_data_header)),
EXPECT_EQ(read(this->bulk_in, buf, size + sizeof(mtp_data_header)),
static_cast<long>(size + sizeof(mtp_data_header)));
struct mtp_data_header *header = reinterpret_cast<struct mtp_data_header*>(buf);
@ -172,7 +229,7 @@ TEST_F(MtpFfsHandleTest, testSendFileSmall) {
EXPECT_EQ(header->transaction_id, static_cast<unsigned int>(1337));
}
TEST_F(MtpFfsHandleTest, testSendFileMed) {
TYPED_TEST(MtpFfsHandleTest, testSendFileMed) {
std::stringstream ss;
mtp_file_range mfr;
mfr.command = 42;
@ -183,14 +240,14 @@ TEST_F(MtpFfsHandleTest, testSendFileMed) {
buf[size + sizeof(mtp_data_header)] = '\0';
mfr.length = size;
mfr.fd = dummy_file.fd;
mfr.fd = this->dummy_file.fd;
for (int i = 0; i < MED_MULT; i++)
ss << dummyDataStr;
EXPECT_EQ(write(dummy_file.fd, ss.str().c_str(), size), size);
EXPECT_EQ(handle->sendFile(mfr), 0);
EXPECT_EQ(write(this->dummy_file.fd, ss.str().c_str(), size), size);
EXPECT_EQ(this->handle->sendFile(mfr), 0);
EXPECT_EQ(read(bulk_in, buf, size + sizeof(mtp_data_header)),
EXPECT_EQ(read(this->bulk_in, buf, size + sizeof(mtp_data_header)),
static_cast<long>(size + sizeof(mtp_data_header)));
struct mtp_data_header *header = reinterpret_cast<struct mtp_data_header*>(buf);
@ -201,10 +258,10 @@ TEST_F(MtpFfsHandleTest, testSendFileMed) {
EXPECT_EQ(header->transaction_id, static_cast<unsigned int>(1337));
}
TEST_F(MtpFfsHandleTest, testSendFileMedPartial) {
TYPED_TEST(MtpFfsHandleTest, testSendFileMedPartial) {
std::stringstream ss;
mtp_file_range mfr;
mfr.fd = dummy_file.fd;
mfr.fd = this->dummy_file.fd;
mfr.command = 42;
mfr.transaction_id = 1337;
int size = TEST_PACKET_SIZE * MED_MULT;
@ -214,7 +271,7 @@ TEST_F(MtpFfsHandleTest, testSendFileMedPartial) {
for (int i = 0; i < MED_MULT; i++)
ss << dummyDataStr;
EXPECT_EQ(write(dummy_file.fd, ss.str().c_str(), size), size);
EXPECT_EQ(write(this->dummy_file.fd, ss.str().c_str(), size), size);
std::random_device rd;
std::mt19937 gen(rd());
@ -225,9 +282,9 @@ TEST_F(MtpFfsHandleTest, testSendFileMedPartial) {
int length = std::min(size - offset, dis(gen));
mfr.length = length;
char temp_buf[length + sizeof(mtp_data_header)];
EXPECT_EQ(handle->sendFile(mfr), 0);
EXPECT_EQ(this->handle->sendFile(mfr), 0);
EXPECT_EQ(read(bulk_in, temp_buf, length + sizeof(mtp_data_header)),
EXPECT_EQ(read(this->bulk_in, temp_buf, length + sizeof(mtp_data_header)),
static_cast<long>(length + sizeof(mtp_data_header)));
struct mtp_data_header *header = reinterpret_cast<struct mtp_data_header*>(temp_buf);
@ -241,7 +298,7 @@ TEST_F(MtpFfsHandleTest, testSendFileMedPartial) {
EXPECT_STREQ(buf, ss.str().c_str());
}
TEST_F(MtpFfsHandleTest, testSendFileEmpty) {
TYPED_TEST(MtpFfsHandleTest, testSendFileEmpty) {
mtp_file_range mfr;
mfr.command = 42;
mfr.transaction_id = 1337;
@ -251,11 +308,11 @@ TEST_F(MtpFfsHandleTest, testSendFileEmpty) {
buf[size + sizeof(mtp_data_header)] = '\0';
mfr.length = size;
mfr.fd = dummy_file.fd;
mfr.fd = this->dummy_file.fd;
EXPECT_EQ(handle->sendFile(mfr), 0);
EXPECT_EQ(this->handle->sendFile(mfr), 0);
EXPECT_EQ(read(bulk_in, buf, size + sizeof(mtp_data_header)),
EXPECT_EQ(read(this->bulk_in, buf, size + sizeof(mtp_data_header)),
static_cast<long>(size + sizeof(mtp_data_header)));
struct mtp_data_header *header = reinterpret_cast<struct mtp_data_header*>(buf);
@ -265,15 +322,15 @@ TEST_F(MtpFfsHandleTest, testSendFileEmpty) {
EXPECT_EQ(header->transaction_id, static_cast<unsigned int>(1337));
}
TEST_F(MtpFfsHandleTest, testSendEvent) {
TYPED_TEST(MtpFfsHandleTest, testSendEvent) {
struct mtp_event event;
event.length = TEST_PACKET_SIZE;
event.data = const_cast<char*>(dummyDataStr.c_str());
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
handle->sendEvent(event);
read(intr, buf, TEST_PACKET_SIZE);
this->handle->sendEvent(event);
read(this->intr, buf, TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}

@ -0,0 +1,100 @@
/*
* Copyright 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#define LOG_TAG "PosixAsyncIO_test.cpp"
#include <android-base/test_utils.h>
#include <fcntl.h>
#include <gtest/gtest.h>
#include <string>
#include <unistd.h>
#include <utils/Log.h>
#include "PosixAsyncIO.h"
namespace android {
constexpr int TEST_PACKET_SIZE = 512;
static const std::string dummyDataStr =
"/*\n * Copyright 2015 The Android Open Source Project\n *\n * Licensed un"
"der the Apache License, Version 2.0 (the \"License\");\n * you may not us"
"e this file except in compliance with the License.\n * You may obtain a c"
"opy of the License at\n *\n * http://www.apache.org/licenses/LICENSE"
"-2.0\n *\n * Unless required by applicable law or agreed to in writing, s"
"oftware\n * distributed under the License is distributed on an \"AS IS\" "
"BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express o"
"r implied.\n * Se";
class PosixAsyncIOTest : public ::testing::Test {
protected:
TemporaryFile dummy_file;
PosixAsyncIOTest() {}
~PosixAsyncIOTest() {}
};
TEST_F(PosixAsyncIOTest, testRead) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
EXPECT_EQ(write(dummy_file.fd, dummyDataStr.c_str(), TEST_PACKET_SIZE), TEST_PACKET_SIZE);
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = dummy_file.fd;
aio.aio_buf = buf;
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_read(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(PosixAsyncIOTest, testWrite) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = dummy_file.fd;
aio.aio_buf = const_cast<char*>(dummyDataStr.c_str());
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_write(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), TEST_PACKET_SIZE);
EXPECT_EQ(read(dummy_file.fd, buf, TEST_PACKET_SIZE), TEST_PACKET_SIZE);
EXPECT_STREQ(buf, dummyDataStr.c_str());
}
TEST_F(PosixAsyncIOTest, testError) {
char buf[TEST_PACKET_SIZE + 1];
buf[TEST_PACKET_SIZE] = '\0';
struct aiocb aio;
struct aiocb *aiol[] = {&aio};
aio.aio_fildes = -1;
aio.aio_buf = const_cast<char*>(dummyDataStr.c_str());
aio.aio_offset = 0;
aio.aio_nbytes = TEST_PACKET_SIZE;
EXPECT_EQ(aio_write(&aio), 0);
EXPECT_EQ(aio_suspend(aiol, 1, nullptr), 0);
EXPECT_EQ(aio_return(&aio), -1);
EXPECT_EQ(aio_error(&aio), EBADF);
}
} // namespace android
Loading…
Cancel
Save