From 6ba3f5e527169386472f0fb0b8ccd3184ecfd435 Mon Sep 17 00:00:00 2001 From: Shuzhen Wang Date: Tue, 20 Nov 2018 10:04:08 -0800 Subject: [PATCH] Camera: Do not update state at HAL starts up if state already exists This is to handle lazy hal, where cameraserver doesn't know HAL goes away. Test: Observe that the between QS Torch Tile and Camera App is correct. Bug: 79374634 Change-Id: I2f802b1c409ba3581f0fcacfc0ac5f6059391139 --- services/camera/libcameraservice/CameraService.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/camera/libcameraservice/CameraService.cpp b/services/camera/libcameraservice/CameraService.cpp index 4dacd0273e..ce35ad9186 100644 --- a/services/camera/libcameraservice/CameraService.cpp +++ b/services/camera/libcameraservice/CameraService.cpp @@ -190,7 +190,9 @@ status_t CameraService::enumerateProviders() { for (auto& cameraId : deviceIds) { String8 id8 = String8(cameraId.c_str()); - onDeviceStatusChanged(id8, CameraDeviceStatus::PRESENT); + if (getCameraState(id8) == nullptr) { + onDeviceStatusChanged(id8, CameraDeviceStatus::PRESENT); + } } return OK;