From a0b8496016dcd98dc9b8086f0d22b14efb7e48f2 Mon Sep 17 00:00:00 2001
From: George Burgess IV <gbiv@google.com>
Date: Tue, 29 Aug 2017 17:46:19 -0700
Subject: [PATCH] libcameraservice: fix static analyzer complaints

Due to https://bugs.llvm.org/show_bug.cgi?id=34365, the static analyzer
complains about use of copied `sp`s. In this case, the copy is entirely
unnecessary, since we're just going to destroy the copied-from sp
anyway.

Speed things up a bit + appease the analyzer by moving instead.

Bug: 27101951
Test: mma. Static analyzer no longer complains.
Change-Id: I148212e418cb3f8728383db92b564523525b633a
---
 .../camera/libcameraservice/common/CameraProviderManager.cpp    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/services/camera/libcameraservice/common/CameraProviderManager.cpp b/services/camera/libcameraservice/common/CameraProviderManager.cpp
index 5addaf18ef..a02090b5b3 100644
--- a/services/camera/libcameraservice/common/CameraProviderManager.cpp
+++ b/services/camera/libcameraservice/common/CameraProviderManager.cpp
@@ -1339,7 +1339,7 @@ status_t HidlVendorTagDescriptor::createDescriptorFromHidl(
         desc->mReverseMapping[reverseIndex]->add(desc->mTagToNameMap.valueFor(tag), tag);
     }
 
-    descriptor = desc;
+    descriptor = std::move(desc);
     return OK;
 }