diff --git a/services/camera/libcameraservice/CameraService.cpp b/services/camera/libcameraservice/CameraService.cpp index c70513c342..44ccbbea0e 100644 --- a/services/camera/libcameraservice/CameraService.cpp +++ b/services/camera/libcameraservice/CameraService.cpp @@ -3271,9 +3271,21 @@ void CameraService::updateStatus(StatusInternal status, const String8& cameraId, return; } bool isHidden = isPublicallyHiddenSecureCamera(cameraId); + bool supportsHAL3 = false; + // supportsCameraApi also holds mInterfaceMutex, we can't call it in the + // HIDL onStatusChanged wrapper call (we'll hold mStatusListenerLock and + // mInterfaceMutex together, which can lead to deadlocks) + binder::Status sRet = + supportsCameraApi(String16(cameraId), hardware::ICameraService::API_VERSION_2, + &supportsHAL3); + if (!sRet.isOk()) { + ALOGW("%s: Failed to determine if device supports HAL3 %s, supportsCameraApi call failed", + __FUNCTION__, cameraId.string()); + return; + } // Update the status for this camera state, then send the onStatusChangedCallbacks to each // of the listeners with both the mStatusStatus and mStatusListenerLock held - state->updateStatus(status, cameraId, rejectSourceStates, [this,&isHidden] + state->updateStatus(status, cameraId, rejectSourceStates, [this, &isHidden, &supportsHAL3] (const String8& cameraId, StatusInternal status) { if (status != StatusInternal::ENUMERATING) { @@ -3295,8 +3307,8 @@ void CameraService::updateStatus(StatusInternal status, const String8& cameraId, Mutex::Autolock lock(mStatusListenerLock); for (auto& listener : mListenerList) { - if (!listener.first && isHidden) { - ALOGV("Skipping camera discovery callback for system-only camera %s", + if (!listener.first && (isHidden || !supportsHAL3)) { + ALOGV("Skipping camera discovery callback for system-only / HAL1 camera %s", cameraId.c_str()); continue; } diff --git a/services/camera/libcameraservice/hidl/HidlCameraService.cpp b/services/camera/libcameraservice/hidl/HidlCameraService.cpp index 74cfe4267a..1daa035aec 100644 --- a/services/camera/libcameraservice/hidl/HidlCameraService.cpp +++ b/services/camera/libcameraservice/hidl/HidlCameraService.cpp @@ -191,6 +191,14 @@ Return HidlCameraService::addListener(const sp& hC _hidl_cb(status, {}); return Void(); } + cameraStatusAndIds.erase(std::remove_if(cameraStatusAndIds.begin(), cameraStatusAndIds.end(), + [this](const hardware::CameraStatus& s) { + bool supportsHAL3 = false; + binder::Status sRet = + mAidlICameraService->supportsCameraApi(String16(s.cameraId), + hardware::ICameraService::API_VERSION_2, &supportsHAL3); + return !sRet.isOk() || !supportsHAL3; + }), cameraStatusAndIds.end()); hidl_vec hCameraStatusAndIds; //Convert cameraStatusAndIds to HIDL and call callback convertToHidl(cameraStatusAndIds, &hCameraStatusAndIds);