Merge "EffectReverb: Fix unsigned integer overflow" into pi-dev

6 years ago · b60d788a3f
parent 8a21f4aaf9 361155ac67
commit b60d788a3f
1 changed files with 2 additions and 1 deletions
--- a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
+++ b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
@ -1966,7 +1966,8 @@ int Reverb_process(effect_handle_t   self,

    if (pContext->bEnabled == LVM_FALSE) {
        if (pContext->SamplesToExitCount > 0) {
-            pContext->SamplesToExitCount -= outBuffer->frameCount;
+            // signed - unsigned will trigger integer overflow if result becomes negative.
+            pContext->SamplesToExitCount -= (ssize_t)outBuffer->frameCount;
        } else {
            status = -ENODATA;
        }