From b7bd4383c9dbebc0d094b33cfe0fc4b8f9b313b2 Mon Sep 17 00:00:00 2001 From: Peter Kalauskas Date: Thu, 15 Nov 2018 17:19:48 -0800 Subject: [PATCH] Camera: Remove superfluous hardware::camera Test: Ensure camera works as before Bug: 79374634 Change-Id: Ie8f0da2ec6e6b855329983a2ec39ef2acf0f3eff --- .../common/CameraProviderManager.cpp | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/services/camera/libcameraservice/common/CameraProviderManager.cpp b/services/camera/libcameraservice/common/CameraProviderManager.cpp index ceca0f8ac9..2b3fe9e1d3 100644 --- a/services/camera/libcameraservice/common/CameraProviderManager.cpp +++ b/services/camera/libcameraservice/common/CameraProviderManager.cpp @@ -263,9 +263,9 @@ status_t CameraProviderManager::setUpVendorTags() { } status_t CameraProviderManager::openSession(const std::string &id, - const sp& callback, + const sp& callback, /*out*/ - sp *session) { + sp *session) { std::lock_guard lock(mInterfaceMutex); @@ -293,9 +293,9 @@ status_t CameraProviderManager::openSession(const std::string &id, } status_t CameraProviderManager::openSession(const std::string &id, - const sp& callback, + const sp& callback, /*out*/ - sp *session) { + sp *session) { std::lock_guard lock(mInterfaceMutex); @@ -711,8 +711,7 @@ status_t CameraProviderManager::ProviderInfo::initialize() { sp listener = mManager->getStatusListener(); for (auto& device : devices) { std::string id; - status_t res = addDevice(device, - hardware::camera::common::V1_0::CameraDeviceStatus::PRESENT, &id); + status_t res = addDevice(device, common::V1_0::CameraDeviceStatus::PRESENT, &id); if (res != OK) { ALOGE("%s: Unable to enumerate camera device '%s': %s (%d)", __FUNCTION__, device.c_str(), strerror(-res), res); @@ -1275,7 +1274,7 @@ CameraProviderManager::ProviderInfo::DeviceInfo3::DeviceInfo3(const std::string& ALOGV("%s: Unable to convert ICameraDevice instance to version 3.5", __FUNCTION__); return; } - sp interface_3_5 = castResult; + sp interface_3_5 = castResult; if (interface_3_5 == nullptr) { ALOGE("%s: Converted ICameraDevice instance to nullptr", __FUNCTION__); return; @@ -1686,7 +1685,7 @@ const char* CameraProviderManager::torchStatusToString(const TorchModeStatus& s) status_t HidlVendorTagDescriptor::createDescriptorFromHidl( - const hardware::hidl_vec& vts, + const hardware::hidl_vec& vts, /*out*/ sp& descriptor) { @@ -1714,7 +1713,7 @@ status_t HidlVendorTagDescriptor::createDescriptorFromHidl( int idx = 0; for (size_t s = 0; s < vts.size(); s++) { - const hardware::camera::common::V1_0::VendorTagSection& section = vts[s]; + const common::V1_0::VendorTagSection& section = vts[s]; const char *sectionName = section.sectionName.c_str(); if (sectionName == NULL) { ALOGE("%s: no section name defined for vendor tag section %zu.", __FUNCTION__, s);