Merge "Add EFFECT_CMD_SET_PARAM parameter checking to Preset Reverb" into lmp-mr1-dev

am: 31b0c9cb33 Change-Id: Ib82a43895e86c6be7254e0be38bdb8905cd11e11
7 years ago · be30bb2645
parent f15220d4fc 31b0c9cb33
commit be30bb2645
1 changed files with 4 additions and 0 deletions
--- a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
+++ b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
@ -1768,6 +1768,10 @@ int Reverb_setParameter (ReverbContext *pContext, void *pParam, void *pValue, in
        if (param != REVERB_PARAM_PRESET) {
            return -EINVAL;
        }
+        if (vsize < (int)sizeof(uint16_t)) {
+            android_errorWriteLog(0x534e4554, "67647856");
+            return -EINVAL;
+        }

        uint16_t preset = *(uint16_t *)pValue;
        ALOGV("set REVERB_PARAM_PRESET, preset %d", preset);