diff --git a/media/libaudiofoundation/AudioContainers.cpp b/media/libaudiofoundation/AudioContainers.cpp index 1bfe3f94c4..31257d533b 100644 --- a/media/libaudiofoundation/AudioContainers.cpp +++ b/media/libaudiofoundation/AudioContainers.cpp @@ -42,6 +42,13 @@ const DeviceTypeSet& getAudioDeviceOutAllScoSet() { return audioDeviceOutAllScoSet; } +const DeviceTypeSet& getAudioDeviceOutAllUsbSet() { + static const DeviceTypeSet audioDeviceOutAllUsbSet = DeviceTypeSet( + std::begin(AUDIO_DEVICE_OUT_ALL_USB_ARRAY), + std::end(AUDIO_DEVICE_OUT_ALL_USB_ARRAY)); + return audioDeviceOutAllUsbSet; +} + const DeviceTypeSet& getAudioDeviceInAllSet() { static const DeviceTypeSet audioDeviceInAllSet = DeviceTypeSet( std::begin(AUDIO_DEVICE_IN_ALL_ARRAY), @@ -49,6 +56,13 @@ const DeviceTypeSet& getAudioDeviceInAllSet() { return audioDeviceInAllSet; } +const DeviceTypeSet& getAudioDeviceInAllUsbSet() { + static const DeviceTypeSet audioDeviceInAllUsbSet = DeviceTypeSet( + std::begin(AUDIO_DEVICE_IN_ALL_USB_ARRAY), + std::end(AUDIO_DEVICE_IN_ALL_USB_ARRAY)); + return audioDeviceInAllUsbSet; +} + bool deviceTypesToString(const DeviceTypeSet &deviceTypes, std::string &str) { if (deviceTypes.empty()) { str = "Empty device types"; diff --git a/media/libaudiofoundation/include/media/AudioContainers.h b/media/libaudiofoundation/include/media/AudioContainers.h index 2a3385b46b..72fda49cde 100644 --- a/media/libaudiofoundation/include/media/AudioContainers.h +++ b/media/libaudiofoundation/include/media/AudioContainers.h @@ -37,7 +37,9 @@ using FormatVector = std::vector; const DeviceTypeSet& getAudioDeviceOutAllSet(); const DeviceTypeSet& getAudioDeviceOutAllA2dpSet(); const DeviceTypeSet& getAudioDeviceOutAllScoSet(); +const DeviceTypeSet& getAudioDeviceOutAllUsbSet(); const DeviceTypeSet& getAudioDeviceInAllSet(); +const DeviceTypeSet& getAudioDeviceInAllUsbSet(); template static std::vector Intersection(const std::set& a, const std::set& b) { diff --git a/media/libaudiohal/impl/Android.bp b/media/libaudiohal/impl/Android.bp index 8669e2a427..e96a68cf3b 100644 --- a/media/libaudiohal/impl/Android.bp +++ b/media/libaudiohal/impl/Android.bp @@ -27,6 +27,7 @@ cc_defaults { "android.hardware.audio.common-util", "android.hidl.allocator@1.0", "android.hidl.memory@1.0", + "libaudiofoundation", "libaudiohal_deathhandler", "libaudioutils", "libbase", diff --git a/media/libaudiohal/impl/ConversionHelperHidl.cpp b/media/libaudiohal/impl/ConversionHelperHidl.cpp index 9f8a5203c3..f29b0f3946 100644 --- a/media/libaudiohal/impl/ConversionHelperHidl.cpp +++ b/media/libaudiohal/impl/ConversionHelperHidl.cpp @@ -17,6 +17,7 @@ #include #define LOG_TAG "HalHidl" +#include #include #include @@ -109,26 +110,22 @@ static std::string deviceAddressToHal(const DeviceAddress& address) { char halAddress[AUDIO_DEVICE_MAX_ADDRESS_LEN]; memset(halAddress, 0, sizeof(halAddress)); audio_devices_t halDevice = static_cast(address.device); - const bool isInput = (halDevice & AUDIO_DEVICE_BIT_IN) != 0; - if (isInput) halDevice &= ~AUDIO_DEVICE_BIT_IN; - if ((!isInput && (halDevice & AUDIO_DEVICE_OUT_ALL_A2DP) != 0) || - (isInput && (halDevice & AUDIO_DEVICE_IN_BLUETOOTH_A2DP) != 0)) { + if (getAudioDeviceOutAllA2dpSet().count(halDevice) > 0 || + halDevice == AUDIO_DEVICE_IN_BLUETOOTH_A2DP) { snprintf(halAddress, sizeof(halAddress), "%02X:%02X:%02X:%02X:%02X:%02X", address.address.mac[0], address.address.mac[1], address.address.mac[2], address.address.mac[3], address.address.mac[4], address.address.mac[5]); - } else if ((!isInput && (halDevice & AUDIO_DEVICE_OUT_IP) != 0) || - (isInput && (halDevice & AUDIO_DEVICE_IN_IP) != 0)) { + } else if (halDevice == AUDIO_DEVICE_OUT_IP || halDevice == AUDIO_DEVICE_IN_IP) { snprintf(halAddress, sizeof(halAddress), "%d.%d.%d.%d", address.address.ipv4[0], address.address.ipv4[1], address.address.ipv4[2], address.address.ipv4[3]); - } else if ((!isInput && (halDevice & AUDIO_DEVICE_OUT_ALL_USB) != 0) || - (isInput && (halDevice & AUDIO_DEVICE_IN_ALL_USB) != 0)) { + } else if (getAudioDeviceOutAllUsbSet().count(halDevice) > 0 || + getAudioDeviceInAllUsbSet().count(halDevice) > 0) { snprintf(halAddress, sizeof(halAddress), "card=%d;device=%d", address.address.alsa.card, address.address.alsa.device); - } else if ((!isInput && (halDevice & AUDIO_DEVICE_OUT_BUS) != 0) || - (isInput && (halDevice & AUDIO_DEVICE_IN_BUS) != 0)) { + } else if (halDevice == AUDIO_DEVICE_OUT_BUS || halDevice == AUDIO_DEVICE_IN_BUS) { snprintf(halAddress, sizeof(halAddress), "%s", address.busAddress.c_str()); - } else if ((!isInput && (halDevice & AUDIO_DEVICE_OUT_REMOTE_SUBMIX)) != 0 || - (isInput && (halDevice & AUDIO_DEVICE_IN_REMOTE_SUBMIX) != 0)) { + } else if (halDevice == AUDIO_DEVICE_OUT_REMOTE_SUBMIX || + halDevice == AUDIO_DEVICE_IN_REMOTE_SUBMIX) { snprintf(halAddress, sizeof(halAddress), "%s", address.rSubmixAddress.c_str()); } else { snprintf(halAddress, sizeof(halAddress), "%s", address.busAddress.c_str()); diff --git a/media/libaudiohal/impl/DeviceHalHidl.cpp b/media/libaudiohal/impl/DeviceHalHidl.cpp index 409a220db1..d52416c96e 100644 --- a/media/libaudiohal/impl/DeviceHalHidl.cpp +++ b/media/libaudiohal/impl/DeviceHalHidl.cpp @@ -22,6 +22,7 @@ #include PATH(android/hardware/audio/FILE_VERSION/IPrimaryDevice.h) #include #include +#include #include #include @@ -51,42 +52,32 @@ status_t deviceAddressFromHal( if (halAddress == nullptr || strnlen(halAddress, AUDIO_DEVICE_MAX_ADDRESS_LEN) == 0) { return OK; } - const bool isInput = (device & AUDIO_DEVICE_BIT_IN) != 0; - if (isInput) device &= ~AUDIO_DEVICE_BIT_IN; - if ((!isInput && (device & AUDIO_DEVICE_OUT_ALL_A2DP) != 0) - || (isInput && (device & AUDIO_DEVICE_IN_BLUETOOTH_A2DP) != 0)) { + if (getAudioDeviceOutAllA2dpSet().count(device) > 0 + || device == AUDIO_DEVICE_IN_BLUETOOTH_A2DP) { int status = sscanf(halAddress, "%hhX:%hhX:%hhX:%hhX:%hhX:%hhX", &address->address.mac[0], &address->address.mac[1], &address->address.mac[2], &address->address.mac[3], &address->address.mac[4], &address->address.mac[5]); return status == 6 ? OK : BAD_VALUE; - } else if ((!isInput && (device & AUDIO_DEVICE_OUT_IP) != 0) - || (isInput && (device & AUDIO_DEVICE_IN_IP) != 0)) { + } else if (device == AUDIO_DEVICE_OUT_IP || device == AUDIO_DEVICE_IN_IP) { int status = sscanf(halAddress, "%hhu.%hhu.%hhu.%hhu", &address->address.ipv4[0], &address->address.ipv4[1], &address->address.ipv4[2], &address->address.ipv4[3]); return status == 4 ? OK : BAD_VALUE; - } else if ((!isInput && (device & AUDIO_DEVICE_OUT_ALL_USB)) != 0 - || (isInput && (device & AUDIO_DEVICE_IN_ALL_USB)) != 0) { + } else if (getAudioDeviceOutAllUsbSet().count(device) > 0 + || getAudioDeviceInAllUsbSet().count(device) > 0) { int status = sscanf(halAddress, "card=%d;device=%d", &address->address.alsa.card, &address->address.alsa.device); return status == 2 ? OK : BAD_VALUE; - } else if ((!isInput && (device & AUDIO_DEVICE_OUT_BUS) != 0) - || (isInput && (device & AUDIO_DEVICE_IN_BUS) != 0)) { - if (halAddress != NULL) { - address->busAddress = halAddress; - return OK; - } - return BAD_VALUE; - } else if ((!isInput && (device & AUDIO_DEVICE_OUT_REMOTE_SUBMIX)) != 0 - || (isInput && (device & AUDIO_DEVICE_IN_REMOTE_SUBMIX) != 0)) { - if (halAddress != NULL) { - address->rSubmixAddress = halAddress; - return OK; - } - return BAD_VALUE; + } else if (device == AUDIO_DEVICE_OUT_BUS || device == AUDIO_DEVICE_IN_BUS) { + address->busAddress = halAddress; + return OK; + } else if (device == AUDIO_DEVICE_OUT_REMOTE_SUBMIX + || device == AUDIO_DEVICE_IN_REMOTE_SUBMIX) { + address->rSubmixAddress = halAddress; + return OK; } return OK; }