In DNG sdk, rectangle's bottom and right are exclusive.
Update DngUtils to be consistent with that.
Also fixed normalized optical center calculation given pixel [0, 0]
is a square centered at (0.5, 0.5).
Test: DngCreatorTest, and visually inspect DNG images taken
Bug: 119566614
Change-Id: I73ab9327f75c24282ae14ef798fef797bb700bae
- Add dummy CFA pattern for monochrome camera.
- Handle monochrome camera in DngCreator.
- Fix up static and dynamic metadata tags related to monochrome camera
for older version of devices.
Test: Camera CTS
Test: Capture a DNG file and inspect with LightRoom
Bug: 70216652
Change-Id: I68d2b3d77b7f81bdc9e4129c2a8af10a4f18db3b
This is moved to the calling code to account for different scaling
needed for different metadata.
Test: DngCreator CTS tests continue to pass, inspecting saved DNGs shows expected values.
Bug: 74641761
Change-Id: Icbfe452b1523df4e440428a432bc3e90147b3cc8
Note that the Adobe DNG 1.4 spec for Bayer phase (defined for the
FixBadPixelsConstant and FixBadPixelsList opcodes) is incorrect. It's
inconsistent with the DNG SDK (cf. dng_negative::SetBayerMosaic and
dng_opcode_FixBadPixelsList::IsGreen), and Adobe confirms that the
spec should be updated to match the SDK.
Test: build
Bug: 78294972
Change-Id: Ie60fb3370b80ed30c8c05505dcfdc873746e244a
We were using an incorrect sample spacing of 1/N instead of 1/(N-1). This affected rendering in 3rd party tools like Adobe Photoshop, effectively shrinking the lens shading map and replicating values from the bottom-most row and right-most column.
Bug: 77657628
Test: created test pattern lens shading maps, loaded DNG in Photoshop
Change-Id: Ia814ebefeceafc72b17058a9c4cf598140d3f752
Due to https://bugs.llvm.org/show_bug.cgi?id=34365, the static analyzer
complains about use of copied `sp`s. In this case, the copy is entirely
unnecessary, since we're just going to destroy the copied-from sp
anyway.
Speed things up a bit + appease the analyzer by moving instead.
Bug: 27101951
Test: mma. Static analyzer no longer complains.
Change-Id: I08f77c2509dc03a919238b97666be3f458ba7cf3
Various media components were linking against dynamic libraries that weren't needed.
Test: built and booted
Change-Id: I7379506fd06d4e28e0eff0001fd073a2d3860f8e
- Switch the BlackLevel entry to be RATIONAL
- Switch to heap allocation instead of stack allocation for lens
shading map construction
- Add orientation enums for convenience
Bug: 25862995
Bug: 27073274
Change-Id: I7031a33c4797dc8b2c8030d26b749066e03bff9e
In the -DNDEBUG case, nextOffset is unused, causing clang to spew a
warning in code build with -Werror.
Change-Id: If0101dcdf735672050f985a1de25a983edb02a52
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
- Fix SubIfd handling.
- Add StripSources, convenience functions for writing image strips.
- Update Input classes to use with JNI.
- Add skip method.
- Add tag definitions for GPS tags.
- Add name string to tag definitions.
Bug: 15112503
Change-Id: I9535b21261027f6c06a041c1621de8f865a0ad32
Adds a native image utilities library with support for:
- Writing TIFF 6.0 and TIFF EP compliant file headers.
- Additional tags defined in EXIF 2.3 and DNG 1.4 specs.
Change-Id: I7a4fef74bd5254d92baf08a3cf61af5de1b7ca83
Shuzhen Wang
Eino-Ville Talvala
Sam Hasinoff
George Burgess IV
Colin Cross
Marco Nelissen
Chih-hung Hsieh
Dimitry Ivanov
Ruben Brunk
Bernhard Rosenkränzer
Andreas Gampe