From aae793802b77cbd18cf93637ee16b36b1734c525 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Fri, 10 Jun 2016 14:13:59 -0700 Subject: [PATCH] Fix misc-macro-parentheses warnings in system/vold. Add parentheses around macro arguments used beside operators. Bug: 28705665 Change-Id: I44e954f15bf6b8279d0f857d5417b7cb457da779 --- VolumeManager.h | 2 +- cryptfs.h | 28 ++++++++++++++-------------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/VolumeManager.h b/VolumeManager.h index 39fc8f9..dd9f09d 100644 --- a/VolumeManager.h +++ b/VolumeManager.h @@ -217,7 +217,7 @@ private: extern "C" { #endif /* __cplusplus */ -#define UNMOUNT_NOT_MOUNTED_ERR -2 +#define UNMOUNT_NOT_MOUNTED_ERR (-2) int vold_unmountAll(void); #ifdef __cplusplus } diff --git a/cryptfs.h b/cryptfs.h index fd6f3da..3754018 100644 --- a/cryptfs.h +++ b/cryptfs.h @@ -178,32 +178,32 @@ struct crypt_persist_data { /* Return values for cryptfs_crypto_complete */ #define CRYPTO_COMPLETE_NOT_ENCRYPTED 1 #define CRYPTO_COMPLETE_ENCRYPTED 0 -#define CRYPTO_COMPLETE_BAD_METADATA -1 -#define CRYPTO_COMPLETE_PARTIAL -2 -#define CRYPTO_COMPLETE_INCONSISTENT -3 -#define CRYPTO_COMPLETE_CORRUPT -4 +#define CRYPTO_COMPLETE_BAD_METADATA (-1) +#define CRYPTO_COMPLETE_PARTIAL (-2) +#define CRYPTO_COMPLETE_INCONSISTENT (-3) +#define CRYPTO_COMPLETE_CORRUPT (-4) /* Return values for cryptfs_enable_inplace*() */ #define ENABLE_INPLACE_OK 0 -#define ENABLE_INPLACE_ERR_OTHER -1 -#define ENABLE_INPLACE_ERR_DEV -2 /* crypto_blkdev issue */ +#define ENABLE_INPLACE_ERR_OTHER (-1) +#define ENABLE_INPLACE_ERR_DEV (-2) /* crypto_blkdev issue */ /* Return values for cryptfs_getfield */ #define CRYPTO_GETFIELD_OK 0 -#define CRYPTO_GETFIELD_ERROR_NO_FIELD -1 -#define CRYPTO_GETFIELD_ERROR_OTHER -2 -#define CRYPTO_GETFIELD_ERROR_BUF_TOO_SMALL -3 +#define CRYPTO_GETFIELD_ERROR_NO_FIELD (-1) +#define CRYPTO_GETFIELD_ERROR_OTHER (-2) +#define CRYPTO_GETFIELD_ERROR_BUF_TOO_SMALL (-3) /* Return values for cryptfs_setfield */ #define CRYPTO_SETFIELD_OK 0 -#define CRYPTO_SETFIELD_ERROR_OTHER -1 -#define CRYPTO_SETFIELD_ERROR_FIELD_TOO_LONG -2 -#define CRYPTO_SETFIELD_ERROR_VALUE_TOO_LONG -3 +#define CRYPTO_SETFIELD_ERROR_OTHER (-1) +#define CRYPTO_SETFIELD_ERROR_FIELD_TOO_LONG (-2) +#define CRYPTO_SETFIELD_ERROR_VALUE_TOO_LONG (-3) /* Return values for persist_del_key */ #define PERSIST_DEL_KEY_OK 0 -#define PERSIST_DEL_KEY_ERROR_OTHER -1 -#define PERSIST_DEL_KEY_ERROR_NO_FIELD -2 +#define PERSIST_DEL_KEY_ERROR_OTHER (-1) +#define PERSIST_DEL_KEY_ERROR_NO_FIELD (-2) #ifdef __cplusplus extern "C" {