From 7929deb206d8c04801deb4a26232f83a55e6fd32 Mon Sep 17 00:00:00 2001 From: Chih-Wei Huang Date: Sun, 10 Feb 2013 22:57:14 +0800 Subject: [PATCH] Fix compiling warnings The patch removes the following warnings: system/vold/vdc.c: In function 'do_cmd': system/vold/vdc.c:71:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [...] In file included from system/vold/Fat.cpp:34:0: bionic/libc/kernel/common/linux/fs.h:109:0: warning: "MS_RMT_MASK" redefined [enabled by default] In file included from system/vold/Fat.cpp:31:0: bionic/libc/include/sys/mount.h:64:0: note: this is the location of the previous definition [...] Change-Id: I1e950dcec87f8bae0cec61a1611126b3abc0c90e --- Devmapper.cpp | 2 +- Ext4.cpp | 1 - Fat.cpp | 1 - Volume.cpp | 1 - vdc.c | 2 +- 5 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Devmapper.cpp b/Devmapper.cpp index 7c11d12..6f43ac0 100644 --- a/Devmapper.cpp +++ b/Devmapper.cpp @@ -124,7 +124,7 @@ void Devmapper::ioctlInit(struct dm_ioctl *io, size_t dataSize, io->version[2] = 0; io->flags = flags; if (name) { - int ret = strlcpy(io->name, name, sizeof(io->name)); + size_t ret = strlcpy(io->name, name, sizeof(io->name)); if (ret >= sizeof(io->name)) abort(); } diff --git a/Ext4.cpp b/Ext4.cpp index 4ec0616..613d623 100644 --- a/Ext4.cpp +++ b/Ext4.cpp @@ -31,7 +31,6 @@ #include #include -#include #define LOG_TAG "Vold" diff --git a/Fat.cpp b/Fat.cpp index 82a3f7a..a7fcc28 100644 --- a/Fat.cpp +++ b/Fat.cpp @@ -31,7 +31,6 @@ #include #include -#include #define LOG_TAG "Vold" diff --git a/Volume.cpp b/Volume.cpp index 0be2e81..4a00ccc 100644 --- a/Volume.cpp +++ b/Volume.cpp @@ -28,7 +28,6 @@ #include #include -#include #include diff --git a/vdc.c b/vdc.c index 7dad143..59f34d6 100644 --- a/vdc.c +++ b/vdc.c @@ -57,7 +57,7 @@ int main(int argc, char **argv) { static int do_cmd(int sock, int argc, char **argv) { char final_cmd[255] = "0 "; /* 0 is a (now required) sequence number */ int i; - int ret; + size_t ret; for (i = 1; i < argc; i++) { char *cmp;