ensure_subdirectory_unmounted() was ignoring the return value from umount(), so it wasn't possible to tell whether it succeeded or failed. Make it log an error message on failure. Also, there might be cases where ensure_subdirectory_unmounted() fails initially but would succeed later, e.g. due to files in a subdirectory mount being open and requiring processes to be killed. To make this more robust, keep calling ensure_subdirectory_unmounted() before each attempt of umount("/data"). I'm not sure whether this will actually fix bug 189250652, as it hasn't been root-caused yet, but this might help. Bug: 189250652 Change-Id: I979b12d3c6a88fe3335ff548b1f8a5db43683c4f (cherry picked from commit 895343006417e62b82ba6f758cf43643f529af2f) Merged-In: I979b12d3c6a88fe3335ff548b1f8a5db43683c4fgugelfrei
parent
3461ff5c9a
commit
ca79199a58
Loading…
Reference in new issue