From 99360d76e548dcf4301669ad7763c90347615861 Mon Sep 17 00:00:00 2001 From: Paul Crowley Date: Wed, 19 Oct 2016 14:00:24 -0700 Subject: [PATCH] Remove misleading comment (b/26948053) Vold is considered part of our trusted computing base, and compromising vold is already identified as a complete device compromise. While storing keys only in the kernel would be better, the current setup does not introduce a security bug or worsen any security control. Bug: 26948053 Test: Comment-only change. Change-Id: Ib5436f4386769ec44b74dc6b50fbcc0fed99b96b --- Ext4Crypt.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Ext4Crypt.cpp b/Ext4Crypt.cpp index e195042..0531aba 100644 --- a/Ext4Crypt.cpp +++ b/Ext4Crypt.cpp @@ -75,8 +75,7 @@ std::set s_ephemeral_users; // Map user ids to key references std::map s_de_key_raw_refs; std::map s_ce_key_raw_refs; -// TODO abolish this map. Keys should not be long-lived in user memory, only kernel memory. -// See b/26948053 +// TODO abolish this map, per b/26948053 std::map s_ce_keys; // ext4enc:TODO get this const from somewhere good