Merge "Add EFFECT_CMD_SET_PARAM parameter checking to Preset Reverb" into lmp-mr1-dev am: 31b0c9cb33

am: be30bb2645 Change-Id: Ia85cd80721ca275aa18030604b72ea361627348b
7 years ago · e2d671ce19
parent 7bccf8fae9 be30bb2645
commit e2d671ce19
1 changed files with 4 additions and 0 deletions
--- a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
+++ b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
@ -1768,6 +1768,10 @@ int Reverb_setParameter (ReverbContext *pContext, void *pParam, void *pValue, in
        if (param != REVERB_PARAM_PRESET) {
            return -EINVAL;
        }
+        if (vsize < (int)sizeof(uint16_t)) {
+            android_errorWriteLog(0x534e4554, "67647856");
+            return -EINVAL;
+        }

        uint16_t preset = *(uint16_t *)pValue;
        ALOGV("set REVERB_PARAM_PRESET, preset %d", preset);