Merge "Convert ifstream usage into fopen() to prevent fd leaks into child processes" am: 93fb6083d4

am: f1dec58b61

Change-Id: Id7e8626129dbda0fdafcc86b087b67f71b5d3f8a
gugelfrei
Suren Baghdasaryan 5 years ago committed by android-build-merger
commit 1efcfc30b1

@ -46,18 +46,27 @@ namespace vold {
static bool checkMaps(const std::string& path, const std::string& prefix) { static bool checkMaps(const std::string& path, const std::string& prefix) {
bool found = false; bool found = false;
std::ifstream infile(path); auto file = std::unique_ptr<FILE, decltype(&fclose)>{fopen(path.c_str(), "re"), fclose};
std::string line; if (!file) {
while (std::getline(infile, line)) { return false;
}
char* buf = nullptr;
size_t len = 0;
while (getline(&buf, &len, file.get()) != -1) {
std::string line(buf);
std::string::size_type pos = line.find('/'); std::string::size_type pos = line.find('/');
if (pos != std::string::npos) { if (pos != std::string::npos) {
line = line.substr(pos); line = line.substr(pos);
if (android::base::StartsWith(line, prefix)) { if (android::base::StartsWith(line, prefix)) {
LOG(WARNING) << "Found map " << path << " referencing " << line; LOG(WARNING) << "Found map " << path << " referencing " << line;
found = true; found = true;
break;
} }
} }
} }
free(buf);
return found; return found;
} }

Loading…
Cancel
Save